Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(gpu): add tests for N=8192 multi-bit PBS #989

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

agnesLeroy
Copy link
Contributor

closes: please link all relevant issues

PR content/description

Check-list:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Relevant issues are marked as resolved/closed, related issues are linked in the description
  • Check for breaking changes (including serialization changes) and add them to commit message following the conventional commit specification

@cla-bot cla-bot bot added the cla-signed label Mar 14, 2024
@agnesLeroy
Copy link
Contributor Author

agnesLeroy commented Mar 14, 2024

@IceTDrinker there may be an issue with MULTI_BIT_MESSAGE_3_CARRY_3 parameter sets. I'm trying to add tests on the multi-bit PBS with those parameters but they fail on CPU and GPU. cc @pdroalves

@IceTDrinker
Copy link
Member

known issue, some of the algorithms needs power of 2 number of bits cc @tmontaigu he knows that better than me

@tmontaigu
Copy link
Contributor

It looks like its core_crypto algorithms that fails not integer ones

@IceTDrinker
Copy link
Member

yes my bad @tmontaigu Agnes told me that, we'll take a look this afternoon

@IceTDrinker
Copy link
Member

ciphertext modulus log is wrong, we have 6 bits, here it has 8

@agnesLeroy agnesLeroy force-pushed the chore/multi_bit_pbs_test branch 2 times, most recently from a5bd527 to f6782b1 Compare March 19, 2024 08:07
@pdroalves pdroalves force-pushed the chore/multi_bit_pbs_test branch from f6782b1 to 7033762 Compare April 12, 2024 12:37
@pdroalves pdroalves force-pushed the chore/multi_bit_pbs_test branch from 7033762 to 0f86803 Compare April 12, 2024 12:48
@pdroalves
Copy link
Contributor

I rebased this PR on the current main and it looks like the bug was fixed at some point between this PR and today. 3_3 core_crypto tests pass and I can run the primitives for polynomial_size=8192.

@IceTDrinker
Copy link
Member

one of the issue was a wrong setting in the parameters, so maybe that fixed it

@agnesLeroy agnesLeroy marked this pull request as ready for review April 15, 2024 07:30
@pdroalves
Copy link
Contributor

@agnesLeroy can we merge this one?

@agnesLeroy agnesLeroy merged commit 666926e into main Apr 19, 2024
13 checks passed
@agnesLeroy agnesLeroy deleted the chore/multi_bit_pbs_test branch April 19, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants