-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(gpu): add tests for N=8192 multi-bit PBS #989
Conversation
@IceTDrinker there may be an issue with MULTI_BIT_MESSAGE_3_CARRY_3 parameter sets. I'm trying to add tests on the multi-bit PBS with those parameters but they fail on CPU and GPU. cc @pdroalves |
known issue, some of the algorithms needs power of 2 number of bits cc @tmontaigu he knows that better than me |
It looks like its core_crypto algorithms that fails not integer ones |
yes my bad @tmontaigu Agnes told me that, we'll take a look this afternoon |
ciphertext modulus log is wrong, we have 6 bits, here it has 8 |
a5bd527
to
f6782b1
Compare
f6782b1
to
7033762
Compare
7033762
to
0f86803
Compare
I rebased this PR on the current main and it looks like the bug was fixed at some point between this PR and today. 3_3 core_crypto tests pass and I can run the primitives for |
one of the issue was a wrong setting in the parameters, so maybe that fixed it |
@agnesLeroy can we merge this one? |
closes: please link all relevant issues
PR content/description
Check-list: