feat(gpu): add support to larger polynomials on multi-bit PBS #976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdroalves
force-pushed
the
feat/gpu/sm_multibit
branch
from
bf953de to
4f5cd18
Compare
|
@slab-ci gpu-test |
|
Failed to run command: command 'gpu-test' not found in config file |
|
@slab-ci gpu_test |
|
http status 422 Unprocessable Entity code not expected |
pdroalves
force-pushed
the
feat/gpu/sm_multibit
branch
from
4f5cd18 to
6f1b4a7
Compare
agnesLeroy
reviewed
Mar 13, 2024
There was a problem hiding this comment.
Hey @pdroalves! Looks really good, thank you very much! I just have a comment about one name choice, otherwise all good 🙂
backends/tfhe-cuda-backend/cuda/src/pbs/programmable_bootstrap_cg_multibit.cuh
Outdated
Show resolved
Hide resolved
backends/tfhe-cuda-backend/cuda/src/pbs/programmable_bootstrap_multibit.cuh
Outdated
Show resolved
Hide resolved
backends/tfhe-cuda-backend/cuda/src/pbs/programmable_bootstrap_multibit.cuh
Show resolved
Hide resolved
backends/tfhe-cuda-backend/cuda/src/pbs/programmable_bootstrap_multibit.cuh
Outdated
Show resolved
Hide resolved
pdroalves
force-pushed
the
feat/gpu/sm_multibit
branch
from
6f1b4a7 to
6d69e7a
Compare
agnesLeroy
reviewed
Mar 13, 2024
backends/tfhe-cuda-backend/cuda/src/pbs/programmable_bootstrap_cg_multibit.cuh
Outdated
Show resolved
Hide resolved
agnesLeroy
reviewed
Mar 13, 2024
backends/tfhe-cuda-backend/cuda/src/pbs/programmable_bootstrap_cg_multibit.cuh
Outdated
Show resolved
Hide resolved
agnesLeroy
reviewed
Mar 13, 2024
backends/tfhe-cuda-backend/cuda/src/pbs/programmable_bootstrap_cg_multibit.cuh
Outdated
Show resolved
Hide resolved
agnesLeroy
approved these changes
Mar 13, 2024
pdroalves
force-pushed
the
feat/gpu/sm_multibit
branch
from
6d69e7a to
a349e0c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: https://github.com/zama-ai/tfhe-rs-internal/issues/455
PR content/description
Check-list: