feat(gpu): reimplement custom benchmarks #956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdroalves
force-pushed
the
feat/gpu/benchmark
branch
from
4140b15 to
fc8cc6b
Compare
pdroalves
force-pushed
the
feat/gpu/benchmark
branch
from
fc8cc6b to
f07e4e6
Compare
pdroalves
force-pushed
the
feat/gpu/benchmark
branch
3 times, most recently
from
be74673 to
51dd78b
Compare
agnesLeroy
reviewed
Mar 7, 2024
There was a problem hiding this comment.
Hey @pdroalves! Thank you very much for this, it was a bit hard to review, I hope I didn't miss anything. Just some minor fixes anyway, and it'll be good to go!
backends/tfhe-cuda-backend/cuda/tests_and_benchmarks/tests/CMakeLists.txt
Show resolved
Hide resolved
pdroalves
force-pushed
the
feat/gpu/benchmark
branch
2 times, most recently
from
9854cb7 to
ad58742
Compare
agnesLeroy
reviewed
Mar 8, 2024
agnesLeroy
reviewed
Mar 8, 2024
backends/tfhe-cuda-backend/cuda/tests_and_benchmarks/benchmarks/CMakeLists.txt
Outdated
Show resolved
Hide resolved
|
may I suggest adding a target in the Makefile to check those internal benchmarks are always compiling ok ? And this check be added to the pcc_gpu :) |
pdroalves
force-pushed
the
feat/gpu/benchmark
branch
4 times, most recently
from
40c4253 to
89928fa
Compare
agnesLeroy
reviewed
Mar 8, 2024
…ll variants and the FFT
pdroalves
force-pushed
the
feat/gpu/benchmark
branch
from
89928fa to
cf572fa
Compare
agnesLeroy
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves https://github.com/zama-ai/tfhe-rs-internal/issues/471
closes: please link all relevant issues
PR content/description
Check-list: