Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bench(gpu): add a benchmark for keyswitch on GPU #851

Merged
merged 2 commits into from
Feb 6, 2024

Conversation

agnesLeroy
Copy link
Contributor

closes: https://github.com/zama-ai/tfhe-rs-internal/issues/446

PR content/description

Check-list:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Relevant issues are marked as resolved/closed, related issues are linked in the description
  • Check for breaking changes (including serialization changes) and add them to commit message following the conventional commit specification

@cla-bot cla-bot bot added the cla-signed label Feb 2, 2024
@agnesLeroy agnesLeroy requested a review from soonum February 2, 2024 10:40
Copy link

github-actions bot commented Feb 2, 2024

@slab-ci gpu_test

Copy link

github-actions bot commented Feb 2, 2024

@slab-ci gpu_test

@agnesLeroy
Copy link
Contributor Author

@soonum not sure you wanted to add the JSON dump there as well?

Copy link
Contributor

@soonum soonum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we send the results to the Postgre database and thus to Grafana ?

tfhe/benches/core_crypto/ks_bench.rs Outdated Show resolved Hide resolved
tfhe/benches/core_crypto/ks_bench.rs Outdated Show resolved Hide resolved
Copy link

github-actions bot commented Feb 2, 2024

@slab-ci gpu_test

@agnesLeroy
Copy link
Contributor Author

@soonum I've added the dump to Json file but I'm not sure it's enough, is there something else missing?

Copy link

github-actions bot commented Feb 2, 2024

@slab-ci gpu_test

@agnesLeroy agnesLeroy requested a review from soonum February 2, 2024 14:53
Copy link
Contributor

@soonum soonum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes ! Thanks for the changes !

@agnesLeroy agnesLeroy merged commit 37b9478 into main Feb 6, 2024
30 checks passed
@agnesLeroy agnesLeroy deleted the bench/gpu/keyswitch branch February 6, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants