Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(gpu): abort when trying to launch 32 bit multi-bit PBS #835

Merged
merged 1 commit into from
Feb 5, 2024
Merged

chore(gpu): abort when trying to launch 32 bit multi-bit PBS #835

merged 1 commit into from
Feb 5, 2024

Conversation

agnesLeroy
Copy link
Contributor

closes: https://github.com/zama-ai/tfhe-rs-internal/issues/276

PR content/description

Check-list:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Relevant issues are marked as resolved/closed, related issues are linked in the description
  • Check for breaking changes (including serialization changes) and add them to commit message following the conventional commit specification

@cla-bot cla-bot bot added the cla-signed label Jan 31, 2024
@agnesLeroy agnesLeroy requested a review from pdroalves January 31, 2024 08:04
@github-actions GitHub Actions
Copy link

@slab-ci cpu_fast_test
@slab-ci gpu_test

pdroalves
pdroalves reviewed Jan 31, 2024
View reviewed changes
Copy link
Contributor

@pdroalves pdroalves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey!

backends/tfhe-cuda-backend/cuda/include/integer.h Outdated Show resolved Hide resolved
backends/tfhe-cuda-backend/cuda/src/integer/integer.cuh Outdated Show resolved Hide resolved
@pdroalves
Copy link
Contributor

@agnesLeroy do you think we should encapsulate this into a templated method in bootstrap_multibit.cu? This way we assert there is nowhere else in the cuda library trying to launch 32-bit operations without going through this PANIC() method.

@agnesLeroy agnesLeroy force-pushed the chore/gpu/multi-bit-abort-32 branch from ec43775 to 9337719 Compare February 1, 2024 08:27
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 1, 2024

@slab-ci gpu_test

@agnesLeroy agnesLeroy force-pushed the chore/gpu/multi-bit-abort-32 branch from 9337719 to c3f2593 Compare February 1, 2024 15:10
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 1, 2024

@slab-ci gpu_test

@agnesLeroy agnesLeroy force-pushed the chore/gpu/multi-bit-abort-32 branch from c3f2593 to 829b068 Compare February 1, 2024 15:12
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 1, 2024

@slab-ci gpu_test

@agnesLeroy agnesLeroy requested a review from pdroalves February 1, 2024 15:12
@agnesLeroy agnesLeroy force-pushed the chore/gpu/multi-bit-abort-32 branch from 829b068 to 33a2683 Compare February 2, 2024 09:42
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 2, 2024

@slab-ci gpu_test

pdroalves
pdroalves approved these changes Feb 2, 2024
View reviewed changes
Copy link
Contributor

@pdroalves pdroalves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @agnesLeroy ! I just added a comment about something you might have forgotten, but this PR seems solid to me.

backends/tfhe-cuda-backend/cuda/src/integer/integer.cuh Outdated Show resolved Hide resolved
@agnesLeroy agnesLeroy force-pushed the chore/gpu/multi-bit-abort-32 branch from 33a2683 to a50e90b Compare February 5, 2024 08:27
@zama-bot zama-bot removed the approved label Feb 5, 2024
@agnesLeroy agnesLeroy force-pushed the chore/gpu/multi-bit-abort-32 branch from a50e90b to e6f0f47 Compare February 5, 2024 08:44
@agnesLeroy agnesLeroy merged commit 5513d3a into main Feb 5, 2024
29 checks passed
@agnesLeroy agnesLeroy deleted the chore/gpu/multi-bit-abort-32 branch February 5, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdroalves pdroalves pdroalves approved these changes

Assignees
No one assigned
Labels
approved cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@agnesLeroy @pdroalves @zama-bot