Fhebool boolean block #681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And add the trait to the prelude so that users can use it.
|
@slab-ci cpu_fast_test |
tmontaigu
force-pushed
the
fhebool-boolean-block
branch
from
6beae51 to
53f72ed
Compare
|
@slab-ci cpu_fast_test |
IceTDrinker
reviewed
Nov 13, 2023
| @@ -159,7 +195,7 @@ impl FheTryEncrypt<bool, CompressedPublicKey> for crate::FheBool { | |||
| fn try_encrypt(value: bool, key: &CompressedPublicKey) -> Result<Self, Self::Error> { | |||
| let key = &key.key; | |||
| let ciphertext = key.key.encrypt(u64::from(value)); | |||
| Ok(Self::new(ciphertext)) | |||
| Ok(Self::new(BooleanBlock::new_unchecked(ciphertext))) | |||
There was a problem hiding this comment.
internally those ops still return a shortint ciphertext ?
There was a problem hiding this comment.
Hum, Yeah I haven't added encryt_bool for the different PublicKey types of integer. Should I add them in this PR ?
There was a problem hiding this comment.
is it a large change ? otherwise it's fine to put it in a separate PR I would say
There was a problem hiding this comment.
I added the 2 missing functions
- This makes FheBool use integer::BooleanBlock internally.
- It makes comparisons (eq, ne, le, etc) return a FheBool instead of
FheUint/FheInt.
- It also moves the if_then_else and cmux methods to FheBool.
- Adds casting from FheBool to FheUint/FheInt (but not from
FheUint/FheInt to FheBool as we expect users to do `a.ne(0)`
as its matches Rust)
BREAKING CHANGE:
- Comparisons now return FheBool
- if_then_else/cmux are now methods of FheBool.
tmontaigu
force-pushed
the
fhebool-boolean-block
branch
from
53f72ed to
ac17660
Compare
|
@slab-ci cpu_fast_test |
|
Pull Request has been approved 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FheUint/FheInt.
FheUint/FheInt to FheBool as we expect users to do
a.ne(0)as its matches Rust)
BREAKING CHANGE:
- Comparisons now return FheBool
- if_then_else/cmux are now methods of FheBool.