chore(integer): restore assert after using 3_3 params for CRT doctests #676
Conversation
|
@slab-ci cpu_fast_test |
|
@slab-ci cpu_fast_test |
|
Pull Request has been approved 🎉 |
|
@slab-ci csprng_randomness_testing |
|
the failure is linked to keys being generated for radix and then loaded for CRT from the cache, several functions are only for the radix case on server keys, I will take the time to update the various functions or it is time to introduce a separate radix and crt server keys, will wait next week |
- fix max degree for CRT keys which don't need to propagate carries BREAKING CHANGE: pub API removed from pub interface
- this was not properly ignoring the keycache if a file had a specific extension
IceTDrinker
force-pushed
the
am/fix/restore-crt-assert
branch
from
9ac0c63 to
57c1edd
Compare
|
@slab-ci cpu_fast_test |
|
doctests run ok on my m6i, still would prefer a proof read for the last things I changed |
|
Pull Request has been approved 🎉 |
closes: https://github.com/zama-ai/tfhe-rs-internal/issues/256
PR content/description
also prevent users to have access to gen_keys which was wrong for the CRT max degree, the old Integer ClientKey is still accessible through as_ref calls, but some convenience functions have been added on the key itself
Some API breaks because of the change
Check-list: