Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): add core_crypto layer to code coverage #664

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

soonum
Copy link
Contributor

@soonum soonum commented Nov 3, 2023

One more layer about to be implemented 🎉

@cla-bot cla-bot bot added the cla-signed label Nov 3, 2023
Copy link

github-actions bot commented Nov 3, 2023

@slab-ci cpu_fast_test

@soonum
Copy link
Contributor Author

soonum commented Nov 3, 2023

@slab-ci code_coverage

Copy link

github-actions bot commented Nov 3, 2023

@slab-ci cpu_fast_test

@soonum
Copy link
Contributor Author

soonum commented Nov 3, 2023

@slab-ci code_coverage

@soonum soonum force-pushed the dt/ci/core_crypto_coverage branch from dabe631 to 09d8682 Compare November 3, 2023 08:42
@soonum
Copy link
Contributor Author

soonum commented Nov 3, 2023

@slab-ci code_coverage

Copy link

github-actions bot commented Nov 3, 2023

@slab-ci cpu_fast_test

@soonum soonum force-pushed the dt/ci/core_crypto_coverage branch from 09d8682 to 62dd1f8 Compare November 3, 2023 08:51
@soonum
Copy link
Contributor Author

soonum commented Nov 3, 2023

@slab-ci code_coverage

Copy link

github-actions bot commented Nov 3, 2023

@slab-ci cpu_fast_test

@soonum soonum force-pushed the dt/ci/core_crypto_coverage branch from 62dd1f8 to e04b77b Compare November 3, 2023 16:49
Copy link

github-actions bot commented Nov 3, 2023

@slab-ci cpu_fast_test

@soonum
Copy link
Contributor Author

soonum commented Nov 3, 2023

@slab-ci code_coverage

@soonum soonum force-pushed the dt/ci/core_crypto_coverage branch from e04b77b to 9e99668 Compare November 6, 2023 09:53
Copy link

github-actions bot commented Nov 6, 2023

@slab-ci cpu_fast_test

@soonum
Copy link
Contributor Author

soonum commented Nov 6, 2023

@slab-ci code_coverage

Copy link

codecov bot commented Nov 6, 2023

Codecov Report

Attention: 119 lines in your changes are missing coverage. Please review.

Comparison is base (ed83fbb) 23.11% compared to head (7ee34e8) 57.63%.
Report is 204 commits behind head on main.

❗ Current head 7ee34e8 differs from pull request most recent head ca14778. Consider uploading reports for the commit ca14778 to get more accurate results

Files Patch % Lines
tfhe/src/conformance.rs 0.00% 23 Missing ⚠️
tfhe/src/boolean/engine/bootstrapping.rs 36.36% 14 Missing ⚠️
.../src/core_crypto/algorithms/glwe_linear_algebra.rs 83.52% 14 Missing ⚠️
...rc/core_crypto/algorithms/lwe_packing_keyswitch.rs 86.11% 10 Missing ⚠️
...c/core_crypto/algorithms/glwe_sample_extraction.rs 84.00% 8 Missing ⚠️
..._crypto/algorithms/lwe_bootstrap_key_conversion.rs 71.42% 8 Missing ⚠️
...gorithms/lwe_multi_bit_bootstrap_key_conversion.rs 0.00% 7 Missing ⚠️
tfhe/src/boolean/keycache.rs 57.14% 6 Missing ⚠️
...ithms/seeded_ggsw_ciphertext_list_decompression.rs 84.21% 6 Missing ⚠️
...rithms/lwe_multi_bit_programmable_bootstrapping.rs 20.00% 4 Missing ⚠️
... and 8 more
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #664       +/-   ##
===========================================
+ Coverage   23.11%   57.63%   +34.52%     
===========================================
  Files         256      263        +7     
  Lines       19573    21003     +1430     
===========================================
+ Hits         4525    12106     +7581     
+ Misses      15048     8897     -6151     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@soonum soonum force-pushed the dt/ci/core_crypto_coverage branch from 9e99668 to d33f789 Compare November 7, 2023 15:52
Copy link

github-actions bot commented Nov 7, 2023

@slab-ci cpu_fast_test

@soonum
Copy link
Contributor Author

soonum commented Nov 7, 2023

@slab-ci code_coverage

@soonum soonum force-pushed the dt/ci/core_crypto_coverage branch from d33f789 to 261f16f Compare November 8, 2023 11:35
Copy link

github-actions bot commented Nov 8, 2023

@slab-ci cpu_fast_test

@soonum
Copy link
Contributor Author

soonum commented Nov 8, 2023

@slab-ci code_coverage

@soonum soonum force-pushed the dt/ci/core_crypto_coverage branch from 261f16f to a10ee02 Compare November 9, 2023 10:16
Copy link

github-actions bot commented Nov 9, 2023

@slab-ci cpu_fast_test

@soonum soonum changed the title Code coverage for core_crypto [WIP] chore(ci): add core_crypto layer to code coverage Nov 9, 2023
@soonum soonum self-assigned this Nov 9, 2023
@soonum soonum added the ci label Nov 9, 2023
@soonum soonum requested a review from IceTDrinker November 9, 2023 10:17
@soonum soonum force-pushed the dt/ci/core_crypto_coverage branch from ba93d89 to 77934a9 Compare November 15, 2023 16:51
Copy link

@slab-ci cpu_fast_test

@slab-ci
Copy link

slab-ci bot commented Nov 15, 2023

Failed to spawn EC2 instances: failed to create aws ec2 instance after many attempts (InsufficientInstanceCapacity(ApiErrorInfo { code: "InsufficientInstanceCapacity", message: "We currently do not have sufficient m6i.32xlarge capacity in zones with support for 'gp2' volumes. Our system will be working on provisioning additional capacity." }))

@soonum soonum force-pushed the dt/ci/core_crypto_coverage branch 3 times, most recently from 192b0d4 to 9ae14a4 Compare November 16, 2023 10:04
Copy link

@slab-ci cpu_fast_test

@soonum
Copy link
Contributor Author

soonum commented Nov 16, 2023

@slab-ci code_coverage

Copy link
Member

@IceTDrinker IceTDrinker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small things still

tfhe/src/core_crypto/algorithms/test/params.rs Outdated Show resolved Hide resolved
tfhe/src/core_crypto/algorithms/test/params.rs Outdated Show resolved Hide resolved
tfhe/src/core_crypto/keycache.rs Outdated Show resolved Hide resolved
tfhe/src/keycache/mod.rs Show resolved Hide resolved
tfhe/src/keycache/mod.rs Outdated Show resolved Hide resolved
tfhe/src/keycache/mod.rs Outdated Show resolved Hide resolved
@soonum soonum force-pushed the dt/ci/core_crypto_coverage branch from 9ae14a4 to 9be4c89 Compare November 20, 2023 13:33
@soonum
Copy link
Contributor Author

soonum commented Nov 20, 2023

@slab-ci code_coverage

@soonum soonum force-pushed the dt/ci/core_crypto_coverage branch from 9be4c89 to 7ee34e8 Compare November 20, 2023 13:50
Copy link

@slab-ci cpu_fast_test

@soonum
Copy link
Contributor Author

soonum commented Nov 20, 2023

@slab-ci code_coverage

@soonum soonum requested a review from IceTDrinker November 20, 2023 13:51
Copy link
Member

@IceTDrinker IceTDrinker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok final stretch

tfhe/src/core_crypto/keycache.rs Outdated Show resolved Hide resolved
tfhe/src/keycache/mod.rs Outdated Show resolved Hide resolved
tfhe/src/core_crypto/algorithms/test/mod.rs Show resolved Hide resolved
@soonum soonum force-pushed the dt/ci/core_crypto_coverage branch from 7ee34e8 to ca14778 Compare November 21, 2023 15:37
Copy link

@slab-ci cpu_fast_test

@soonum soonum requested a review from IceTDrinker November 21, 2023 15:37
Copy link
Member

@IceTDrinker IceTDrinker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All right let's go 🚀

Copy link

Pull Request has been approved 🎉
Launching full test suite...
@slab-ci cpu_test
@slab-ci cpu_integer_test
@slab-ci cpu_multi_bit_test
@slab-ci cpu_wasm_test
@slab-ci csprng_randomness_testing

@soonum soonum merged commit c2d7f17 into main Nov 22, 2023
18 checks passed
@soonum soonum deleted the dt/ci/core_crypto_coverage branch November 22, 2023 09:21
@soonum
Copy link
Contributor Author

soonum commented Nov 22, 2023

Resolves: zama-ai/tfhe-rs-internal#230

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants