fix(shortint): error message in packing keyswitch #1974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayeul-zama
reviewed
Jan 15, 2025
| @@ -46,7 +46,7 @@ impl CompressionKey { | |||
|
|
|||
| assert!( | |||
| message_modulus.0 <= carry_modulus.0, | |||
| "GLWE packing is implemented with messages in carries, so carry_modulus (={}) can't be bigger than message_modulus(={})", | |||
| "GLWE packing is implemented with messages in carries, so carry_modulus (={}) must be bigger than message_modulus(={})", | |||
There was a problem hiding this comment.
I guess I meant message_modulus can't be bigger than carry_modulus (understood in the sense strictly bigger).
It think using the "must be bigger or equal" or inverting (as I meant) would be clearer
nsarlin-zama
force-pushed
the
ns/fix/errmsg_packing_ks
branch
from
4709c16 to
7ebd0ab
Compare
nsarlin-zama
force-pushed
the
ns/fix/errmsg_packing_ks
branch
from
7ebd0ab to
cd96bde
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.