feat(gpu): implement fhe rand on gpu #1958
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guillermo-oyarzun
force-pushed
the
go/feature/implement-fherand-on-gpu
branch
from
349cfaa to
9088fb0
Compare
agnesLeroy
reviewed
Jan 14, 2025
There was a problem hiding this comment.
Hey @guillermo-oyarzun! Thanks a lot for this PR, here comes my review. My main question is about the par_generate... entry points: at the moment the cuda calls are made on the same streams, which makes execution sequential. What we could do is use a different set of streams for each of the par_iter iteration maybe? Wdyt?
guillermo-oyarzun
force-pushed
the
go/feature/implement-fherand-on-gpu
branch
2 times, most recently
from
d870628 to
5d54d65
Compare
guillermo-oyarzun
force-pushed
the
go/feature/implement-fherand-on-gpu
branch
from
5d54d65 to
63eb9b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: please link all relevant issues
PR content/description
Check-list: