Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Al/update benchmark table links #1952

Closed
wants to merge 23 commits into from
Closed

Al/update benchmark table links #1952

wants to merge 23 commits into from

Conversation

agnesLeroy
Copy link
Contributor

closes: please link all relevant issues

PR content/description

Check-list:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Relevant issues are marked as resolved/closed, related issues are linked in the description
  • Check for breaking changes (including serialization changes) and add them to commit message following the conventional commit specification

yuxizama and others added 17 commits January 7, 2025 17:27
@yuxizama @IceTDrinker
chore(docs): update discord link
b9ddeeb
@soonum
chore(ci): remove pull_request which duplicate pull_request_target
3690ad0 
Previously pull_request and pull_request_target events were both
emitted thus leading one cancelling the other because of
concurrency group name format.
Since external contribution needs to be allowed we only need
pull_request_target event.
@soonum
chore(ci): relocate permission checking after should-run step
ba105cd 
This induces a failure if the job has to run AND if the triggering actor isn't a member of the zama-ai organization. That would help tfhe-rs maintainers to re-run only workflows that are supposed to run.

The reference is selected based on the event emitted.

We also now use token with restricted permission to check out the repository.
@agnesLeroy
chore(test): modify cpu multi-bit parameters for noise test
a668112
@nsarlin-zama
fix(bench): use correct name for parameters in wasm benches
9ac89fc
@nsarlin-zama
chore: add js fmt to "make conformance"
adf52ac 
and remove linelint autofix which has false positives
@IceTDrinker
chore(ci): make test names unique for fft and ntt
cdcba5c
@IceTDrinker
chore(ci): make cargo-builds-ntt unique to ntt
9a4b584
@nsarlin-zama
chore(trivium): fix params, reverted back to gaussian
a9fb3e9
@soonum
chore(ci): push tfhe-cuda-backend to crates.io unconditionally
f633eed
@soonum
chore(ci): put back weekly core_crypto benchmarks
6fb1332
@guillermo-oyarzun @agnesLeroy
fix(gpu): fix cornercase in match value function
d2a3450
@IceTDrinker
chore: enable strings for docs.rs generation
baefb7d
@nsarlin-zama
chore(backward): move compat tests to avoid compiling them everytime
cd5b3c6
@nsarlin-zama
chore(zk): add bench zk v1 vs v2
4c8d55f
@nsarlin-zama
chore: enable space in editorconfig for more file types
c9eef7d
@nsarlin-zama
chore: formatting uniformization for c and js
ee1a534
@cla-bot cla-bot bot added the cla-signed label Jan 13, 2025
@github-actions GitHub Actions
Copy link

⚠️ This PR contains unsigned commits. To get your PR merged, please sign those commits (git rebase --exec 'git commit -S --amend --no-edit -n' @{upstream}) and force push them to this branch (git push --force-with-lease).

If you're new to commit signing, there are different ways to set it up:

Sign commits with gpg

Follow the steps below to set up commit signing with gpg:

  1. Generate a GPG key
  2. Add the GPG key to your GitHub account
  3. Configure git to use your GPG key for commit signing
Sign commits with ssh-agent

Follow the steps below to set up commit signing with ssh-agent:

  1. Generate an SSH key and add it to ssh-agent
  2. Add the SSH key to your GitHub account
  3. Configure git to use your SSH key for commit signing
Sign commits with 1Password

You can also sign commits using 1Password, which lets you sign commits with biometrics without the signing key leaving the local 1Password process.

Learn how to use 1Password to sign your commits.

Watch the demo

@agnesLeroy agnesLeroy force-pushed the al/update_benchmark_table_links branch from df7648f to 1a823d0 Compare January 13, 2025 10:25
@IceTDrinker
Copy link
Member

@agnesLeroy this does not look right, there are several commits

@agnesLeroy agnesLeroy force-pushed the al/update_benchmark_table_links branch from 1a823d0 to d5eaf6a Compare January 13, 2025 14:00
@agnesLeroy agnesLeroy closed this Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IceTDrinker IceTDrinker Awaiting requested review from IceTDrinker

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@agnesLeroy @IceTDrinker @yuxizama @soonum @nsarlin-zama @guillermo-oyarzun @mayeul-zama @andrei-stoian-zama @tmontaigu