chore(ci): improve pull_request_target handling on fast aws tests #1921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously pull_request and pull_request_target events were both emitted thus leading one cancelling the other because of concurrency group name format. Since external contribution needs to be allowed we only need pull_request_target event.
IceTDrinker
reviewed
Jan 7, 2025
IceTDrinker
reviewed
Jan 7, 2025
IceTDrinker
reviewed
Jan 7, 2025
IceTDrinker
reviewed
Jan 7, 2025
soonum
force-pushed
the
dt/ci/remove_event
branch
from
5d9592a to
fac718d
Compare
IceTDrinker
approved these changes
Jan 7, 2025
|
ah damn the lint did not work as we use some should run properties somewhere see https://github.com/zama-ai/tfhe-rs/actions/runs/12653100464/job/35257456503?pr=1921 |
soonum
force-pushed
the
dt/ci/remove_event
branch
from
fac718d to
4b831aa
Compare
IceTDrinker
reviewed
Jan 7, 2025
This induces a failure if the job has to run AND if the triggering actor isn't a member of the zama-ai organization. That would help tfhe-rs maintainers to re-run only workflows that are supposed to run. The reference is selected based on the event emitted. We also now use token with restricted permission to check out the repository.
soonum
force-pushed
the
dt/ci/remove_event
branch
from
4b831aa to
7e4176f
Compare
IceTDrinker
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two commits to fix issues induced by handling pull_request_target to allow external contributions.