Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(gpu): implement subarray search #1885

Merged
merged 1 commit into from
Dec 20, 2024
Merged

feat(gpu): implement subarray search #1885

merged 1 commit into from
Dec 20, 2024

Conversation

guillermo-oyarzun
Copy link
Member

closes: please link all relevant issues

PR content/description

Check-list:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Relevant issues are marked as resolved/closed, related issues are linked in the description
  • Check for breaking changes (including serialization changes) and add them to commit message following the conventional commit specification

@guillermo-oyarzun guillermo-oyarzun self-assigned this Dec 17, 2024
@cla-bot cla-bot bot added the cla-signed label Dec 17, 2024
@guillermo-oyarzun guillermo-oyarzun force-pushed the go/feature/implement-subarray-search-gpu branch 3 times, most recently from eac469f to 262e773 Compare December 17, 2024 10:35
agnesLeroy
agnesLeroy reviewed Dec 17, 2024
View reviewed changes
Copy link
Contributor

@agnesLeroy agnesLeroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @guillermo-oyarzun! Thanks a lot for this PR: lots of things going on here 😅 Here comes a first round of review. I asked for Rust examples of the pub default functions, assuming there are some on the CPU side. If it's not the case maybe we can go without it as it'll require quite a lot of time to write them from scratch.
Also, is there a benchmark for this function on CPU?

tfhe/src/integer/gpu/server_key/radix/vector_find.rs Outdated Show resolved Hide resolved
tfhe/src/integer/gpu/server_key/radix/vector_find.rs Outdated Show resolved Hide resolved
tfhe/src/integer/gpu/server_key/radix/vector_find.rs Outdated Show resolved Hide resolved
tfhe/src/integer/gpu/server_key/radix/vector_find.rs Outdated Show resolved Hide resolved
tfhe/src/integer/gpu/server_key/radix/vector_find.rs Outdated Show resolved Hide resolved
tfhe/src/integer/gpu/server_key/radix/vector_find.rs Show resolved Hide resolved
tfhe/src/integer/gpu/server_key/radix/vector_find.rs Show resolved Hide resolved
tfhe/src/integer/gpu/server_key/radix/vector_find.rs Show resolved Hide resolved
tfhe/src/integer/gpu/server_key/radix/scalar_comparison.rs Outdated Show resolved Hide resolved
tfhe/src/integer/gpu/server_key/radix/scalar_comparison.rs Outdated Show resolved Hide resolved
@guillermo-oyarzun
Copy link
Member Author

Hey @guillermo-oyarzun! Thanks a lot for this PR: lots of things going on here 😅 Here comes a first round of review. I asked for Rust examples of the pub default functions, assuming there are some on the CPU side. If it's not the case maybe we can go without it as it'll require quite a lot of time to write them from scratch. Also, is there a benchmark for this function on CPU?

There are no examples on the CPU side, that's why i didn't add them. I could try to generate them from the tests, as you prefer. For the benches, how can I check that?

@guillermo-oyarzun guillermo-oyarzun force-pushed the go/feature/implement-subarray-search-gpu branch 4 times, most recently from 978bfbe to 419edbf Compare December 18, 2024 18:09
@guillermo-oyarzun guillermo-oyarzun force-pushed the go/feature/implement-subarray-search-gpu branch from 419edbf to f49bbd7 Compare December 19, 2024 09:30
agnesLeroy
agnesLeroy approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@agnesLeroy agnesLeroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@guillermo-oyarzun guillermo-oyarzun force-pushed the go/feature/implement-subarray-search-gpu branch from f49bbd7 to 91e48f4 Compare December 19, 2024 14:44
@zama-bot zama-bot removed the approved label Dec 19, 2024
@guillermo-oyarzun guillermo-oyarzun merged commit 70ff0f7 into main Dec 20, 2024
53 of 57 checks passed
@guillermo-oyarzun guillermo-oyarzun deleted the go/feature/implement-subarray-search-gpu branch December 20, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agnesLeroy agnesLeroy agnesLeroy approved these changes

Assignees

@guillermo-oyarzun guillermo-oyarzun

Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@guillermo-oyarzun @agnesLeroy @zama-bot