Al/rework difference check #1871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Even though you're going to rework comparisons @guillermo-oyarzun we gain 3 ms with this (going from 29 ms to 26 ms on greater than) so since it's a very little change maybe we could merge it. |
agnesLeroy
force-pushed
the
al/rework_difference_check
branch
from
6bb0bf7 to
efdefa9
Compare
agnesLeroy
force-pushed
the
al/rework_difference_check
branch
from
efdefa9 to
50c8f5f
Compare
guillermo-oyarzun
approved these changes
Dec 13, 2024
agnesLeroy
force-pushed
the
al/rework_difference_check
branch
from
50c8f5f to
ffff833
Compare
agnesLeroy
force-pushed
the
al/rework_difference_check
branch
from
ffff833 to
3ebd208
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: please link all relevant issues
PR content/description
Check-list: