refactor!: use strong types for outputs of DispersionParameters trait fns #1845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IceTDrinker
force-pushed
the
am/refactor/dispersion-strong-types
branch
from
33a56ef to
c731615
Compare
|
this is part of the clean up tasks we wanted to do, I'm working around those so did the refactor here |
mayeul-zama
reviewed
Dec 4, 2024
| @@ -93,7 +93,7 @@ fn lwe_compact_public_key_encryption_expected_variance( | |||
| lwe_dimension: LweDimension, | |||
| ) -> Variance { | |||
| let input_variance = input_noise.get_variance(); | |||
| Variance(input_variance * (lwe_dimension.to_lwe_size().0 as f64)) | |||
| Variance(input_variance.0 * (lwe_dimension.to_lwe_size().0 as f64)) | |||
There was a problem hiding this comment.
We could have a Mul<Rhs = usize> for 'Variance'
There was a problem hiding this comment.
I did not want to update the usability, just that we return strong types, this can be done in a follow up
There was a problem hiding this comment.
| @@ -25,7 +25,7 @@ impl Gaussian<f64> { | |||
|
|
|||
| pub fn from_dispersion_parameter(dispersion: impl DispersionParameter, mean: f64) -> Self { | |||
| Self { | |||
| std: dispersion.get_standard_dev(), | |||
| std: dispersion.get_standard_dev().0, | |||
There was a problem hiding this comment.
Maybe we could remove the generic and make std a StandardDev
There was a problem hiding this comment.
not really as it would mean making StandardDev a generic, so I did not touch the design, just updated the functions to be more type safe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.