Al/test device other than zero #1827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agnesLeroy
force-pushed
the
al/test_device_other_than_zero
branch
from
17076b8 to
6e36e67
Compare
tmontaigu
reviewed
Nov 28, 2024
There was a problem hiding this comment.
I think we need to improve this as it might get too easy to get confused between what is meant to index in the gpu_indexes array or what is a gpu_index as in the index cuda associate to the gpu
Re-introducing the new type GpuIndex for some APIs might be worth
agnesLeroy
force-pushed
the
al/test_device_other_than_zero
branch
3 times, most recently
from
df68e54 to
c0b31f0
Compare
|
@tmontaigu I pushed a commit to the branch to reintroduce a GpuIndex type. |
tmontaigu
approved these changes
Dec 2, 2024
agnesLeroy
force-pushed
the
al/test_device_other_than_zero
branch
from
c0b31f0 to
dc6c3fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: please link all relevant issues
PR content/description
Check-list: