function executor in string tests

[mayeul-zama]

No description provided.

[IceTDrinker]

can you show an example of a conflict case ?

[tmontaigu]

impl<F, I1, O> FunctionExecutor<I1, O> for CpuFunctionExecutor<F>
where
    F: Fn(&ServerKey, I1) -> O,
    I1: NotTuple,
{
    fn execute(&mut self, input: I1) -> O {
        let sks = self.sks.as_ref().expect("setup was not properly called");
        (self.func)(sks, input)
    }
}

conflicts with

impl<F, I1, I2 O> FunctionExecutor<I1, O> for CpuFunctionExecutor<F>
where
    F: Fn(&ServerKey, I1) -> O,
    I1: NotTuple,
{
    fn execute(&mut self, input: (I1, I2)) -> O {
        let sks = self.sks.as_ref().expect("setup was not properly called");
        (self.func)(sks, input)
    }
}

Because the first case input: I1 conflicts with input: (I1, I2)

[IceTDrinker]

cargo build is red and there is a conflict

[IceTDrinker]

Looked good to me, @tmontaigu if you have an opinion on the generic implementation for the CPU executor stuff

[tmontaigu]

I see some P: Into<PBSParameters> + Clone which surprisesme we need the clone

One minor thing that is not done on the integer tests, that slightly improves readability is to give an explicit name to the executor, e.g:

    param: P,
    mut eq_ingore_case_executor: T,
    f: for<'a> fn(&'a str, &'a str) -> bool,
) {
//...
}

[tmontaigu]

impl<F, I1, O> FunctionExecutor<I1, O> for CpuFunctionExecutor<F>
where
    F: Fn(&ServerKey, I1) -> O,
    I1: NotTuple,
{
    fn execute(&mut self, input: I1) -> O {
        let sks = self.sks.as_ref().expect("setup was not properly called");
        (self.func)(sks, input)
    }
}

conflicts with

impl<F, I1, I2 O> FunctionExecutor<I1, O> for CpuFunctionExecutor<F>
where
    F: Fn(&ServerKey, I1) -> O,
    I1: NotTuple,
{
    fn execute(&mut self, input: (I1, I2)) -> O {
        let sks = self.sks.as_ref().expect("setup was not properly called");
        (self.func)(sks, input)
    }
}

Because the first case input: I1 conflicts with input: (I1, I2)

[tmontaigu]

👌

[mayeul-zama]

One minor thing that is not done on the integer tests, that slightly improves readability is to give an explicit name to the executor, e.g:

    param: P,
    mut eq_ingore_case_executor: T,
    f: for<'a> fn(&'a str, &'a str) -> bool,
) {
//...
}

Renamed executors and f as clear_function