Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Al/long run tests #1805

Merged
merged 1 commit into from
Nov 25, 2024
Merged

Al/long run tests #1805

merged 1 commit into from
Nov 25, 2024

Conversation

agnesLeroy
Copy link
Contributor

closes: please link all relevant issues

PR content/description

Check-list:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Relevant issues are marked as resolved/closed, related issues are linked in the description
  • Check for breaking changes (including serialization changes) and add them to commit message following the conventional commit specification

soonum
soonum reviewed Nov 21, 2024
View reviewed changes
Copy link
Contributor

@soonum soonum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI looks fine to me beside cosmetic stuff.

.github/workflows/gpu_integer_long_run_tests.yml Show resolved Hide resolved
.github/workflows/gpu_integer_long_run_tests.yml Outdated Show resolved Hide resolved
.github/workflows/gpu_integer_long_run_tests.yml Outdated Show resolved Hide resolved
@agnesLeroy agnesLeroy force-pushed the al/long_run_tests branch 2 times, most recently from 2cfd921 to b0ed2a5 Compare November 25, 2024 09:35
@agnesLeroy agnesLeroy requested a review from soonum November 25, 2024 09:36
@agnesLeroy
Copy link
Contributor Author

The tests are not very long to run, around half an hour on CPU & GPU. The idea is to add more tests later on.

@agnesLeroy agnesLeroy merged commit 832703a into main Nov 25, 2024
97 of 98 checks passed
@agnesLeroy agnesLeroy deleted the al/long_run_tests branch November 25, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soonum soonum soonum approved these changes

@tmontaigu tmontaigu Awaiting requested review from tmontaigu

Assignees
No one assigned
Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@agnesLeroy @soonum @zama-bot