Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Am/refactor/use natural decomposition order #1747

Merged
merged 4 commits into from
Nov 5, 2024
Merged

Am/refactor/use natural decomposition order #1747

merged 4 commits into from
Nov 5, 2024

Conversation

IceTDrinker
Copy link
Member

No description provided.

@cla-bot cla-bot bot added the cla-signed label Nov 4, 2024
@IceTDrinker IceTDrinker added approved data_PR This is a PR that needs to fetch new data for backward compat tests labels Nov 4, 2024
@IceTDrinker IceTDrinker force-pushed the am/refactor/use-natural-decomposition-order branch from a97223c to 8b25aa9 Compare November 4, 2024 15:13
@zama-bot zama-bot removed the approved label Nov 4, 2024
@IceTDrinker IceTDrinker force-pushed the am/refactor/use-natural-decomposition-order branch from 8b25aa9 to 2adfe71 Compare November 4, 2024 15:48
@zama-bot zama-bot removed the approved label Nov 4, 2024
@IceTDrinker IceTDrinker force-pushed the am/refactor/use-natural-decomposition-order branch from 2adfe71 to c163189 Compare November 4, 2024 16:07
@zama-bot zama-bot removed the approved label Nov 4, 2024
@IceTDrinker IceTDrinker marked this pull request as ready for review November 4, 2024 16:19
@IceTDrinker
Copy link
Member Author

for @agnesLeroy focus on the GPU stuff

agnesLeroy
agnesLeroy reviewed Nov 4, 2024
View reviewed changes
Copy link
Contributor

@agnesLeroy agnesLeroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me as it is, I'm trying to come up with the corresponding change on GPU.

@agnesLeroy
Copy link
Contributor

Draft PR here, let's see if the tests pass, if they do we can port the changes to this branch: #1749. Would be good to run benchmarks as well when the tests have passed to check it does not introduce a regression on performance.

@agnesLeroy
Copy link
Contributor

GPU tests are passing on the draft PR and benchmark results are not affected, we can go with it imo.

@IceTDrinker
Copy link
Member Author

ok @agnesLeroy should I include the patch in my PR ?

@agnesLeroy
Copy link
Contributor

Yes 👍

@IceTDrinker IceTDrinker force-pushed the am/refactor/use-natural-decomposition-order branch from c163189 to 4b5aceb Compare November 5, 2024 09:26
@zama-bot zama-bot removed the approved label Nov 5, 2024
@IceTDrinker IceTDrinker mentioned this pull request Nov 5, 2024
Closed
4 tasks
nsarlin-zama
nsarlin-zama reviewed Nov 5, 2024
View reviewed changes
tfhe/src/high_level_api/backward_compatibility/keys.rs
Comment on lines +30 to +32
impl Deprecable for ServerKey {
const TYPE_NAME: &'static str = "ServerKey";
const MIN_SUPPORTED_APP_VERSION: &'static str = "TFHE-rs v0.10";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this really needed ? Since the different key types are each independently versioned, I'm not sure if we need to deprecate the higher level ones.
The deprecation will be caught during the deserialization of the inner type.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same comment applies to all types that are not directly composed of a level container.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought about it but the error message would be less clear in that case if we don't do a mass deprecation, let me know what you think we should do, worse case I can revert some of the changes, but as they are done now does not matter much normally and I'd rather avoid unnecessary changes now to get the thing ready for the blockchain

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes makes sense, I think we can keep it like this

nsarlin-zama
nsarlin-zama approved these changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

@nsarlin-zama nsarlin-zama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me !

@IceTDrinker @agnesLeroy
refactor(tfhe)!: update key level order for better performance
f8b382b 
- use natural order for decomposition levels in bsk

co-authored-by: Agnes Leroy <[email protected]>
@agnesLeroy agnesLeroy force-pushed the am/refactor/use-natural-decomposition-order branch from 4b5aceb to f8b382b Compare November 5, 2024 10:11
@zama-bot zama-bot removed the approved label Nov 5, 2024
@IceTDrinker IceTDrinker merged commit 615ed3d into main Nov 5, 2024
93 checks passed
@IceTDrinker IceTDrinker deleted the am/refactor/use-natural-decomposition-order branch November 5, 2024 16:23
@zama-bot zama-bot mentioned this pull request Nov 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agnesLeroy agnesLeroy agnesLeroy left review comments

@nsarlin-zama nsarlin-zama nsarlin-zama approved these changes

Assignees
No one assigned
Labels
approved cla-signed data_PR This is a PR that needs to fetch new data for backward compat tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@IceTDrinker @agnesLeroy @nsarlin-zama @zama-bot