chore(ci): check dependencies licenses with cargo-deny #1692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soonum
force-pushed
the
dt/ci/cargo_deny
branch
from
b5b46f5 to
ce21845
Compare
soonum
force-pushed
the
dt/ci/cargo_deny
branch
from
ce21845 to
05e474a
Compare
IceTDrinker
reviewed
Oct 17, 2024
| @@ -0,0 +1,4 @@ | |||
|
|
|||
| # cargo-vet audits file | |||
There was a problem hiding this comment.
how does this work for configuration ?
There was a problem hiding this comment.
cargo-vet needs it to perform the audit (store acquisition).
Comment on lines
+8
to
+14
| allow = [ | ||
| "MIT", | ||
| "BSD-3-Clause", | ||
| "ISC", | ||
| "Apache-2.0", | ||
| "Unicode-DFS-2016" | ||
| ] |
There was a problem hiding this comment.
@aquint-zama those are good to use ?
Comment on lines
+1
to
+5
|
|
||
| # cargo-vet config file | ||
|
|
||
| [cargo-vet] | ||
| version = "0.10" |
There was a problem hiding this comment.
how does the config work here ?
There was a problem hiding this comment.
It's auto generated on cargo vet init and refreshed after a run of cargo vet
|
until we understand how the files and configs function I'm a bit wary to merge this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: zama-ai/tfhe-rs-internal#793