Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): include snippets folder into tfhe npm package #1592

Merged
merged 2 commits into from
Sep 26, 2024

Conversation

soonum
Copy link
Contributor

@soonum soonum commented Sep 26, 2024

No description provided.

@soonum soonum added the ci label Sep 26, 2024
@soonum soonum requested a review from IceTDrinker September 26, 2024 10:13
@soonum soonum self-assigned this Sep 26, 2024
@cla-bot cla-bot bot added the cla-signed label Sep 26, 2024
Makefile Show resolved Hide resolved
Copy link
Member

@IceTDrinker IceTDrinker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for the principle, I believe jq has an in place mode to modify files

@soonum soonum requested a review from IceTDrinker September 26, 2024 11:14
Copy link
Member

@IceTDrinker IceTDrinker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot !

@soonum soonum merged commit 41fae73 into main Sep 26, 2024
71 of 72 checks passed
@soonum soonum deleted the dt/ci/fix_npm_build branch September 26, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants