Tm/scalar cmps #1574
Merged
Tm/scalar cmps #1574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tfhe/src/integer/server_key/radix_parallel/scalar_comparison.rs
Outdated
Show resolved
Hide resolved
tfhe/src/integer/server_key/radix_parallel/scalar_comparison.rs
Outdated
Show resolved
Hide resolved
tfhe/src/integer/server_key/radix_parallel/scalar_comparison.rs
Outdated
Show resolved
Hide resolved
This makes the logic for signed cmps more similar whether the parameters are 1_1 or higher. This will make possible to reuse this part of the code for scalar comparisons
tmontaigu
force-pushed
the
tm/scalar-cmps
branch
from
a63bf1f to
70e644a
Compare
nsarlin-zama
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.