Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(zk): add metadata to v2 #1565

Merged
merged 1 commit into from
Sep 23, 2024
Merged

feat(zk): add metadata to v2 #1565

merged 1 commit into from
Sep 23, 2024

Conversation

nsarlin-zama
Copy link
Contributor

closes: please link all relevant issues

PR content/description

This mirrors what ha been done with zk v1: adds the metadata to the hash operations.

Check-list:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Relevant issues are marked as resolved/closed, related issues are linked in the description
  • Check for breaking changes (including serialization changes) and add them to commit message following the conventional commit specification

@cla-bot cla-bot bot added the cla-signed label Sep 20, 2024
IceTDrinker
IceTDrinker approved these changes Sep 20, 2024
View reviewed changes
Copy link
Member

@IceTDrinker IceTDrinker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@nsarlin-zama nsarlin-zama merged commit a631904 into main Sep 23, 2024
140 of 141 checks passed
@nsarlin-zama nsarlin-zama deleted the ns/metadata_zk_v2 branch September 23, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IceTDrinker IceTDrinker IceTDrinker approved these changes

Assignees
No one assigned
Labels
approved cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nsarlin-zama @IceTDrinker @zama-bot