Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gpu): remove all resettings of shared memory size #1553

Merged
merged 2 commits into from
Sep 24, 2024
Merged

fix(gpu): remove all resettings of shared memory size #1553

merged 2 commits into from
Sep 24, 2024

Conversation

agnesLeroy
Copy link
Contributor

closes: please link all relevant issues

PR content/description

Check-list:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Relevant issues are marked as resolved/closed, related issues are linked in the description
  • Check for breaking changes (including serialization changes) and add them to commit message following the conventional commit specification

@cla-bot cla-bot bot added the cla-signed label Sep 18, 2024
@agnesLeroy agnesLeroy marked this pull request as ready for review September 18, 2024 14:04
@agnesLeroy agnesLeroy marked this pull request as draft September 18, 2024 14:28
@zama-bot zama-bot removed the approved label Sep 20, 2024
@zama-bot zama-bot removed the approved label Sep 23, 2024
@agnesLeroy agnesLeroy marked this pull request as ready for review September 23, 2024 09:21
@agnesLeroy
fix(gpu): add back cuda device synchronize in Drop
7104c24 
It was too unsafe to remove device_synchronize. A good
move would probably to remove all asynchronous entry
points on the Rust side if we want to be safe,
otherwise we need to keep this.
@agnesLeroy
fix(gpu): remove all resettings of shared memory size
460648b
@zama-bot zama-bot removed the approved label Sep 23, 2024
pdroalves
pdroalves approved these changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@pdroalves pdroalves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only doubt is regarding setting cudaFuncCachePreferShared. Since it's the same value I don't think this is a race condition. We could keep it.

backends/tfhe-cuda-backend/cuda/src/pbs/bootstrapping_key.cuh Show resolved Hide resolved
tfhe/src/core_crypto/gpu/vec.rs Show resolved Hide resolved
@agnesLeroy agnesLeroy merged commit 1c0b6fb into main Sep 24, 2024
96 checks passed
@agnesLeroy agnesLeroy deleted the al/remove_sm_resets branch September 24, 2024 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdroalves pdroalves pdroalves approved these changes

Assignees
No one assigned
Labels
approved cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@agnesLeroy @pdroalves @zama-bot