Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: expand_with_key was not providing the safest set of modes #1546

Merged
merged 2 commits into from
Sep 19, 2024
Merged

fix: expand_with_key was not providing the safest set of modes #1546

merged 2 commits into from
Sep 19, 2024

Conversation

IceTDrinker
Copy link
Member

  • it meant that lists needing unpacking could crash during expand

added non reg test

@IceTDrinker
fix: expand_with_key was not providing the safest set of modes
e0551ab 
- it meant that lists needing unpacking could crash during expand
@cla-bot cla-bot bot added the cla-signed label Sep 17, 2024
nsarlin-zama
nsarlin-zama approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@nsarlin-zama nsarlin-zama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the comments :)

@IceTDrinker IceTDrinker merged commit d9662da into main Sep 19, 2024
86 of 87 checks passed
@IceTDrinker IceTDrinker deleted the am/fix/expand-with-key-modes branch September 19, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nsarlin-zama nsarlin-zama nsarlin-zama approved these changes

Assignees
No one assigned
Labels
approved cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@IceTDrinker @nsarlin-zama @zama-bot