chore(gpu): improve compression tests #1543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agnesLeroy
approved these changes
Sep 16, 2024
pdroalves
force-pushed
the
pa/chore/improve_compression_test
branch
from
b267c68 to
361ff87
Compare
pdroalves
force-pushed
the
pa/chore/improve_compression_test
branch
from
361ff87 to
66b9cd5
Compare
|
A downside of this new test is that we no longer test having heterogenous types in the same list as now we test one line with unsigned, another list with signed and another one with booleans |
pdroalves
force-pushed
the
pa/chore/improve_compression_test
branch
from
66b9cd5 to
0cf2c8d
Compare
|
@tmontaigu Good point. I added a third case that pseudo-randomly mix unsigneds, signeds, and booleans. |
pdroalves
force-pushed
the
pa/chore/improve_compression_test
branch
from
0cf2c8d to
fb9fb9e
Compare
pdroalves
force-pushed
the
pa/chore/improve_compression_test
branch
from
fb9fb9e to
7d57bf3
Compare
tmontaigu
approved these changes
Sep 19, 2024
pdroalves
merged commit 0037502
into
pa/chore/compression_checks
76 of 79 checks passed
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: https://github.com/zama-ai/tfhe-rs-internal/issues/724
PR content/description
Check-list: