chore(tfhe): update boolean and shortint parameters #1531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IceTDrinker
reviewed
Sep 12, 2024
| @@ -2,40 +2,39 @@ use crate::core_crypto::prelude::*; | |||
| use crate::shortint::ciphertext::MaxNoiseLevel; | |||
There was a problem hiding this comment.
not sure we want to change those for now (multi bit analysis in progress)
|
we likely need to check with Sam first (and JB as the changes are relatively minor) |
IceTDrinker
reviewed
Sep 23, 2024
IceTDrinker
reviewed
Sep 24, 2024
soonum
force-pushed
the
dt/chore/update_params
branch
2 times, most recently
from
74b2005 to
98c6b66
Compare
soonum
force-pushed
the
dt/chore/update_params
branch
from
98c6b66 to
c8de71f
Compare
IceTDrinker
reviewed
Sep 24, 2024
IceTDrinker
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.