-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement GPU signed scalar div, add scalar div to the hl api #1529
Conversation
b5d50ce
to
4e8bdc4
Compare
58e25e1
to
ec45bcc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Agnes!
I was not able to review the HL API. Regarding the integer part, I missed the assign_async
/async
logic we always use for those operators.
ec45bcc
to
50019e0
Compare
@pdroalves I modified the PR, I changed also the cast functions to have sync/async variants. The PR is significantly bigger now but I think this improves things a lot, thank you very much for your review. |
The hlapi part looks good |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good! Just added two minor comments. There is a forgotten unsafe clause.
Also add overflowing sub to hl
50019e0
to
6ef1729
Compare
closes: please link all relevant issues
PR content/description
Check-list: