Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Go/feature/implement many luts #1528

Merged
merged 1 commit into from
Sep 18, 2024
Merged

Go/feature/implement many luts #1528

merged 1 commit into from
Sep 18, 2024

Conversation

guillermo-oyarzun
Copy link
Member

closes: please link all relevant issues

PR content/description

Check-list:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Relevant issues are marked as resolved/closed, related issues are linked in the description
  • Check for breaking changes (including serialization changes) and add them to commit message following the conventional commit specification

@guillermo-oyarzun guillermo-oyarzun self-assigned this Sep 11, 2024
@cla-bot cla-bot bot added the cla-signed label Sep 11, 2024
@guillermo-oyarzun guillermo-oyarzun force-pushed the go/feature/implement-many-luts branch 3 times, most recently from 2ac2560 to aa78403 Compare September 11, 2024 15:51
@guillermo-oyarzun guillermo-oyarzun force-pushed the go/feature/implement-many-luts branch from aa78403 to 1f159d2 Compare September 13, 2024 11:43
@cla-bot cla-bot bot added the cla-signed label Sep 13, 2024
@zama-bot zama-bot removed the approved label Sep 13, 2024
@guillermo-oyarzun guillermo-oyarzun force-pushed the go/feature/implement-many-luts branch from 1f159d2 to dd80b8d Compare September 13, 2024 12:10
agnesLeroy
agnesLeroy reviewed Sep 13, 2024
View reviewed changes
Copy link
Contributor

@agnesLeroy agnesLeroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I just have a question about some leftover comments. Thank you! 🙂

tfhe/src/integer/gpu/server_key/radix/mod.rs Outdated Show resolved Hide resolved
tfhe/src/integer/gpu/server_key/radix/mod.rs Outdated Show resolved Hide resolved
@guillermo-oyarzun guillermo-oyarzun force-pushed the go/feature/implement-many-luts branch from dd80b8d to 9d04885 Compare September 16, 2024 06:52
@guillermo-oyarzun guillermo-oyarzun force-pushed the go/feature/implement-many-luts branch from 9d04885 to 9d6cfa6 Compare September 16, 2024 06:52
@agnesLeroy agnesLeroy merged commit fc21804 into main Sep 18, 2024
84 of 87 checks passed
@agnesLeroy agnesLeroy deleted the go/feature/implement-many-luts branch September 18, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agnesLeroy agnesLeroy agnesLeroy approved these changes

Assignees

@guillermo-oyarzun guillermo-oyarzun

Labels
approved cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@guillermo-oyarzun @agnesLeroy @zama-bot