Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(gpu): implement conversion between CudaCompressedCiphertextList and CompressedCiphertextList #1524

Merged
merged 3 commits into from
Sep 18, 2024
Merged

feat(gpu): implement conversion between CudaCompressedCiphertextList and CompressedCiphertextList #1524

merged 3 commits into from
Sep 18, 2024

Conversation

pdroalves
Copy link
Contributor

@pdroalves pdroalves commented Sep 10, 2024 •
edited
Loading

closes: https://github.com/zama-ai/tfhe-rs-internal/issues/708

PR content/description

Check-list:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Relevant issues are marked as resolved/closed, related issues are linked in the description
  • Check for breaking changes (including serialization changes) and add them to commit message following the conventional commit specification

@cla-bot cla-bot bot added the cla-signed label Sep 10, 2024
Base automatically changed from pa/fix/multigpu_compression to main September 10, 2024 21:11
@pdroalves pdroalves force-pushed the pa/feat/convert_compression branch from f36cfcb to 65031af Compare September 11, 2024 14:15
@pdroalves pdroalves changed the title feat(gpu): implement conversion from CudaCompressedCiphertextList to CompressedCiphertextList feat(gpu): implement conversion between CudaCompressedCiphertextList and CompressedCiphertextList Sep 11, 2024
@pdroalves pdroalves marked this pull request as ready for review September 11, 2024 14:16
@pdroalves pdroalves force-pushed the pa/feat/convert_compression branch 3 times, most recently from b600d25 to 9c979aa Compare September 11, 2024 14:25
@pdroalves
Copy link
Contributor Author

@agnesLeroy degree logic changed and now we have doc tests :-)

@pdroalves pdroalves force-pushed the pa/feat/convert_compression branch from d01f700 to 2380d79 Compare September 11, 2024 15:11
@pdroalves pdroalves requested a review from tmontaigu September 11, 2024 15:33
@pdroalves pdroalves force-pushed the pa/feat/convert_compression branch from 2380d79 to 4e6d195 Compare September 12, 2024 16:19
@pdroalves pdroalves force-pushed the pa/feat/convert_compression branch from 4e6d195 to f4a98c9 Compare September 13, 2024 11:50
@pdroalves pdroalves requested a review from tmontaigu September 13, 2024 11:51
@agnesLeroy
Copy link
Contributor

@tmontaigu I think after this PR there will be some changes to make in the HL API to make compression on GPU available there, I just don't know what's needed exactly we'll probably need a hand there. 🙂

@pdroalves pdroalves force-pushed the pa/feat/convert_compression branch from f4a98c9 to e70794a Compare September 16, 2024 12:04
@pdroalves pdroalves requested a review from tmontaigu September 16, 2024 12:04
@pdroalves pdroalves force-pushed the pa/feat/convert_compression branch from e70794a to 6e67dd6 Compare September 16, 2024 12:06
@pdroalves pdroalves merged commit 040e28d into main Sep 18, 2024
83 of 85 checks passed
@pdroalves pdroalves deleted the pa/feat/convert_compression branch September 18, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmontaigu tmontaigu tmontaigu approved these changes

@agnesLeroy agnesLeroy Awaiting requested review from agnesLeroy

Assignees
No one assigned
Labels
approved cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pdroalves @agnesLeroy @tmontaigu @zama-bot