Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(core): add noise formulas and variance tests for KS and PBS #1508

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

IceTDrinker
Copy link
Member

No description provided.

@cla-bot cla-bot bot added the cla-signed label Sep 3, 2024
@IceTDrinker IceTDrinker force-pushed the am/test/add-some-noise-formulas branch from 919fd9a to 50de8b2 Compare September 18, 2024 15:39
@IceTDrinker IceTDrinker force-pushed the am/test/add-some-noise-formulas branch from 50de8b2 to 0138d87 Compare September 18, 2024 15:44
pbs_decomposition_level_count,
modulus_as_f64,
)
.0,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need .0 here

Copy link
Contributor

@nsarlin-zama nsarlin-zama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me !

@IceTDrinker
Copy link
Member Author

going to correct the small thing I saw before merging

@IceTDrinker IceTDrinker force-pushed the am/test/add-some-noise-formulas branch from 0138d87 to 56c8cae Compare September 20, 2024 13:09
@zama-bot zama-bot removed the approved label Sep 20, 2024
@IceTDrinker IceTDrinker merged commit 97822db into main Sep 23, 2024
87 checks passed
@IceTDrinker IceTDrinker deleted the am/test/add-some-noise-formulas branch September 23, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants