Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(hlapi): bind cuda's trailing/leading_ones/zeros, ilog2 #1504

Merged
merged 1 commit into from
Sep 4, 2024
Merged

feat(hlapi): bind cuda's trailing/leading_ones/zeros, ilog2 #1504

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
82 changes: 64 additions & 18 deletions tfhe/src/high_level_api/integers/signed/base.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,9 +260,17 @@ where
crate::FheUint32::new(result)
}
#[cfg(feature = "gpu")]
InternalServerKey::Cuda(_) => {
panic!("Cuda devices do not support leading_zeros yet");
}
InternalServerKey::Cuda(cuda_key) => with_thread_local_cuda_streams(|streams| {
let result = cuda_key
.key
.leading_zeros(&*self.ciphertext.on_gpu(), streams);
let result = cuda_key.key.cast_to_unsigned(
result,
crate::FheUint32Id::num_blocks(cuda_key.key.message_modulus),
streams,
);
crate::FheUint32::new(result)
}),
})
}

Expand Down Expand Up @@ -296,9 +304,17 @@ where
crate::FheUint32::new(result)
}
#[cfg(feature = "gpu")]
InternalServerKey::Cuda(_) => {
panic!("Cuda devices do not support leading_ones yet");
}
InternalServerKey::Cuda(cuda_key) => with_thread_local_cuda_streams(|streams| {
let result = cuda_key
.key
.leading_ones(&*self.ciphertext.on_gpu(), streams);
let result = cuda_key.key.cast_to_unsigned(
result,
crate::FheUint32Id::num_blocks(cuda_key.key.message_modulus),
streams,
);
crate::FheUint32::new(result)
}),
})
}

Expand Down Expand Up @@ -332,9 +348,17 @@ where
crate::FheUint32::new(result)
}
#[cfg(feature = "gpu")]
InternalServerKey::Cuda(_) => {
panic!("Cuda devices do not support trailing_zeros yet");
}
InternalServerKey::Cuda(cuda_key) => with_thread_local_cuda_streams(|streams| {
let result = cuda_key
.key
.trailing_zeros(&*self.ciphertext.on_gpu(), streams);
let result = cuda_key.key.cast_to_unsigned(
result,
crate::FheUint32Id::num_blocks(cuda_key.key.message_modulus),
streams,
);
crate::FheUint32::new(result)
}),
})
}

Expand Down Expand Up @@ -368,9 +392,17 @@ where
crate::FheUint32::new(result)
}
#[cfg(feature = "gpu")]
InternalServerKey::Cuda(_) => {
panic!("Cuda devices do not support trailing_ones yet");
}
InternalServerKey::Cuda(cuda_key) => with_thread_local_cuda_streams(|streams| {
let result = cuda_key
.key
.trailing_ones(&*self.ciphertext.on_gpu(), streams);
let result = cuda_key.key.cast_to_unsigned(
result,
crate::FheUint32Id::num_blocks(cuda_key.key.message_modulus),
streams,
);
crate::FheUint32::new(result)
}),
})
}

Expand Down Expand Up @@ -406,9 +438,15 @@ where
crate::FheUint32::new(result)
}
#[cfg(feature = "gpu")]
InternalServerKey::Cuda(_) => {
panic!("Cuda devices do not support ilog2 yet");
}
InternalServerKey::Cuda(cuda_key) => with_thread_local_cuda_streams(|streams| {
let result = cuda_key.key.ilog2(&*self.ciphertext.on_gpu(), streams);
let result = cuda_key.key.cast_to_unsigned(
result,
crate::FheUint32Id::num_blocks(cuda_key.key.message_modulus),
streams,
);
crate::FheUint32::new(result)
}),
})
}

Expand Down Expand Up @@ -448,9 +486,17 @@ where
(crate::FheUint32::new(result), FheBool::new(is_ok))
}
#[cfg(feature = "gpu")]
InternalServerKey::Cuda(_) => {
panic!("Cuda devices do not support checked_ilog2 yet");
}
InternalServerKey::Cuda(cuda_key) => with_thread_local_cuda_streams(|streams| {
let (result, is_ok) = cuda_key
.key
.checked_ilog2(&*self.ciphertext.on_gpu(), streams);
let result = cuda_key.key.cast_to_unsigned(
result,
crate::FheUint32Id::num_blocks(cuda_key.key.message_modulus),
streams,
);
(crate::FheUint32::new(result), FheBool::new(is_ok))
}),
})
}

Expand Down
82 changes: 64 additions & 18 deletions tfhe/src/high_level_api/integers/unsigned/base.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -362,9 +362,17 @@ where
super::FheUint32::new(result)
}
#[cfg(feature = "gpu")]
InternalServerKey::Cuda(_) => {
panic!("Cuda devices do not support leading_zeros yet");
}
InternalServerKey::Cuda(cuda_key) => with_thread_local_cuda_streams(|streams| {
let result = cuda_key
.key
.leading_zeros(&*self.ciphertext.on_gpu(), streams);
let result = cuda_key.key.cast_to_unsigned(
result,
super::FheUint32Id::num_blocks(cuda_key.key.message_modulus),
streams,
);
super::FheUint32::new(result)
}),
})
}

Expand Down Expand Up @@ -398,9 +406,17 @@ where
super::FheUint32::new(result)
}
#[cfg(feature = "gpu")]
InternalServerKey::Cuda(_) => {
panic!("Cuda devices do not support leading_ones yet");
}
InternalServerKey::Cuda(cuda_key) => with_thread_local_cuda_streams(|streams| {
let result = cuda_key
.key
.leading_ones(&*self.ciphertext.on_gpu(), streams);
let result = cuda_key.key.cast_to_unsigned(
result,
super::FheUint32Id::num_blocks(cuda_key.key.message_modulus),
streams,
);
super::FheUint32::new(result)
}),
})
}

Expand Down Expand Up @@ -434,9 +450,17 @@ where
super::FheUint32::new(result)
}
#[cfg(feature = "gpu")]
InternalServerKey::Cuda(_) => {
panic!("Cuda devices do not support trailing_zeros yet");
}
InternalServerKey::Cuda(cuda_key) => with_thread_local_cuda_streams(|streams| {
let result = cuda_key
.key
.trailing_zeros(&*self.ciphertext.on_gpu(), streams);
let result = cuda_key.key.cast_to_unsigned(
result,
super::FheUint32Id::num_blocks(cuda_key.key.message_modulus),
streams,
);
super::FheUint32::new(result)
}),
})
}

Expand Down Expand Up @@ -470,9 +494,17 @@ where
super::FheUint32::new(result)
}
#[cfg(feature = "gpu")]
InternalServerKey::Cuda(_) => {
panic!("Cuda devices do not support trailing_ones yet");
}
InternalServerKey::Cuda(cuda_key) => with_thread_local_cuda_streams(|streams| {
let result = cuda_key
.key
.trailing_ones(&*self.ciphertext.on_gpu(), streams);
let result = cuda_key.key.cast_to_unsigned(
result,
super::FheUint32Id::num_blocks(cuda_key.key.message_modulus),
streams,
);
super::FheUint32::new(result)
}),
})
}

Expand Down Expand Up @@ -508,9 +540,15 @@ where
super::FheUint32::new(result)
}
#[cfg(feature = "gpu")]
InternalServerKey::Cuda(_) => {
panic!("Cuda devices do not support ilog2 yet");
}
InternalServerKey::Cuda(cuda_key) => with_thread_local_cuda_streams(|streams| {
let result = cuda_key.key.ilog2(&*self.ciphertext.on_gpu(), streams);
let result = cuda_key.key.cast_to_unsigned(
result,
super::FheUint32Id::num_blocks(cuda_key.key.message_modulus),
streams,
);
super::FheUint32::new(result)
}),
})
}

Expand Down Expand Up @@ -550,9 +588,17 @@ where
(super::FheUint32::new(result), FheBool::new(is_ok))
}
#[cfg(feature = "gpu")]
InternalServerKey::Cuda(_) => {
panic!("Cuda devices do not support checked_ilog2 yet");
}
InternalServerKey::Cuda(cuda_key) => with_thread_local_cuda_streams(|streams| {
let (result, is_ok) = cuda_key
.key
.checked_ilog2(&*self.ciphertext.on_gpu(), streams);
let result = cuda_key.key.cast_to_unsigned(
result,
super::FheUint32Id::num_blocks(cuda_key.key.message_modulus),
streams,
);
(super::FheUint32::new(result), FheBool::new(is_ok))
}),
})
}

Expand Down
24 changes: 24 additions & 0 deletions tfhe/src/high_level_api/integers/unsigned/tests/gpu.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,3 +121,27 @@ fn test_is_even_is_odd_gpu_multibit() {
let client_key = setup_gpu(Some(PARAM_MULTI_BIT_MESSAGE_2_CARRY_2_GROUP_3_KS_PBS));
super::test_case_is_even_is_odd(&client_key);
}

#[test]
fn test_leading_trailing_zeros_ones_gpu() {
let client_key = setup_default_gpu();
super::test_case_leading_trailing_zeros_ones(&client_key);
}

#[test]
fn test_leading_trailing_zeros_ones_gpu_multibit() {
let client_key = setup_gpu(Some(PARAM_MULTI_BIT_MESSAGE_2_CARRY_2_GROUP_3_KS_PBS));
super::test_case_leading_trailing_zeros_ones(&client_key);
}

#[test]
fn test_ilog2_gpu() {
let client_key = setup_default_gpu();
super::test_case_ilog2(&client_key);
}

#[test]
fn test_ilog2_multibit() {
let client_key = setup_gpu(Some(PARAM_MULTI_BIT_MESSAGE_2_CARRY_2_GROUP_3_KS_PBS));
super::test_case_ilog2(&client_key);
}
mayeul-zama marked this conversation as resolved.
Show resolved Hide resolved
Loading