feat(integer): improve comparison algorithm #1500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IceTDrinker
reviewed
Sep 2, 2024
tfhe/src/integer/server_key/radix_parallel/tests_signed/test_comparison.rs
Show resolved
Hide resolved
|
also are we sure we test the sequential version of |
|
The extensive trivial does |
tmontaigu
force-pushed
the
tm/unsigned-cmps
branch
from
5c576f9 to
f6b4967
Compare
|
crash in the tests when looking at the noise level, trivials have a noise level < Nominal as it's Zero 😅 |
tmontaigu
force-pushed
the
tm/unsigned-cmps
branch
from
f6b4967 to
56add99
Compare
tmontaigu
force-pushed
the
tm/unsigned-cmps
branch
from
56add99 to
3d8d1e3
Compare
Use subtraction to do comparisons lt/le/gt/ge
tmontaigu
force-pushed
the
tm/unsigned-cmps
branch
from
3d8d1e3 to
743ea60
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.