Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore/add slsa framework #1493

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Chore/add slsa framework #1493

wants to merge 4 commits into from

Conversation

aquint-zama
Copy link
Contributor

closes: please link all relevant issues

PR content/description

Check-list:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Relevant issues are marked as resolved/closed, related issues are linked in the description
  • Check for breaking changes (including serialization changes) and add them to commit message following the conventional commit specification

@cla-bot cla-bot bot added the cla-signed label Aug 27, 2024
@IceTDrinker
Copy link
Member

looks like there is an issue the workflow linting

@aquint-zama aquint-zama force-pushed the chore/add-slsa-framework branch from ba1da2b to 718a930 Compare August 27, 2024 13:22
@aquint-zama
Copy link
Contributor Author

looks like there is an issue the workflow linting

Solved, but I'd like to go over the cuda one with you if possible

IceTDrinker
IceTDrinker reviewed Aug 29, 2024
View reviewed changes
Copy link
Member

@IceTDrinker IceTDrinker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks as discussed, putting comments on the PR on what we talked about

.github/workflows/make_release_concrete_tfhe_versionable.yml Outdated Show resolved Hide resolved
.github/workflows/make_release_cuda.yml Outdated Show resolved Hide resolved
@IceTDrinker
Copy link
Member

any updates on this @aquint-zama ?

@aquint-zama
Copy link
Contributor Author

Now that releases are done we could maybe finish it

@IceTDrinker
Copy link
Member

I grabbed the provenance file and it will be in the 0.8.0 release

@aquint-zama aquint-zama force-pushed the chore/add-slsa-framework branch from 718a930 to 9986680 Compare October 4, 2024 12:50
@aquint-zama aquint-zama force-pushed the chore/add-slsa-framework branch from 9986680 to c3d784d Compare October 4, 2024 12:52
@IceTDrinker
Copy link
Member

@aquint-zama do we want to get this done so that then we don't have to come back to this PR ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IceTDrinker IceTDrinker IceTDrinker left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aquint-zama @IceTDrinker