chore(integer): addition test based on trivial inputs #1484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IceTDrinker
reviewed
Aug 22, 2024
tfhe/src/integer/server_key/radix_parallel/tests_unsigned/test_add.rs
Outdated
Show resolved
Hide resolved
This adds `overflowing_add` and `add` tests that are on trivial inputs. As these are faster to run they can be more extensive than on true encryptions This also binds the advanced_add_assign functions tests to include overflow computation On a standard laptop with 1 test thread it takes ~7 minutes to run these trivial tests
tmontaigu
force-pushed
the
tm/extensive-trivial-add
branch
from
d39c35c to
ed5d028
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
overflowing_addandaddtests thatare on trivial inputs. As these are faster to run they can be more extensive than on true encryptions
This also binds the advanced_add_assign functions tests to include overflow computation
On a standard laptop with 1 test thread it takes ~7 minutes to run these trivial tests