Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(wasm): add missing push_u{512,1024,2048} #1475

Merged
merged 2 commits into from
Aug 19, 2024
Merged

feat(wasm): add missing push_u{512,1024,2048} #1475

merged 2 commits into from
Aug 19, 2024

Conversation

tmontaigu
Copy link
Contributor

This adds the missing push functions for some big
uint type that the fhEVM needs

Check-list:

  • Tests for the changes have been added (for bug fixes / features)

@cla-bot cla-bot bot added the cla-signed label Aug 16, 2024
@tmontaigu tmontaigu requested a review from IceTDrinker August 16, 2024 10:59
IceTDrinker
IceTDrinker reviewed Aug 16, 2024
View reviewed changes
Copy link
Member

@IceTDrinker IceTDrinker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks can you first push the version bump to be able to prepare alpha 3 ?

@tmontaigu
Copy link
Contributor Author

In the same PR or another ?

@IceTDrinker
Copy link
Member

this one I think in an additional commit as discussed on Slack

@tmontaigu
chore(tfhe): bump version to 0.8.0-alpha.3
febaf12
@tmontaigu
feat(wasm): add missing push_u{512,1024,2048}
53d159a 
This adds the missing push functions for some big
uint type that the fhEVM needs
@tmontaigu tmontaigu force-pushed the tm/wasm-push-with-bits branch from 890d83c to 53d159a Compare August 16, 2024 11:48
IceTDrinker
IceTDrinker approved these changes Aug 16, 2024
View reviewed changes
Copy link
Member

@IceTDrinker IceTDrinker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@tmontaigu tmontaigu merged commit 3f318a2 into main Aug 19, 2024
87 checks passed
@tmontaigu tmontaigu deleted the tm/wasm-push-with-bits branch August 19, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IceTDrinker IceTDrinker IceTDrinker approved these changes

Assignees
No one assigned
Labels
approved cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tmontaigu @IceTDrinker @zama-bot