Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ci): transfer all GPU CI to hyperstack #1460

Merged
merged 1 commit into from
Aug 7, 2024
Merged

chore(ci): transfer all GPU CI to hyperstack #1460

merged 1 commit into from
Aug 7, 2024

Conversation

agnesLeroy
Copy link
Contributor

closes: please link all relevant issues

PR content/description

Check-list:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Relevant issues are marked as resolved/closed, related issues are linked in the description
  • Check for breaking changes (including serialization changes) and add them to commit message following the conventional commit specification

@cla-bot cla-bot bot added the cla-signed label Aug 6, 2024
@agnesLeroy agnesLeroy force-pushed the al/gpu_ci_on_hyperstack branch from b7f70ee to 7ce17be Compare August 6, 2024 12:07
@agnesLeroy agnesLeroy requested a review from jborfila August 6, 2024 12:09
@agnesLeroy agnesLeroy force-pushed the al/gpu_ci_on_hyperstack branch 2 times, most recently from a7c8a2a to ddbb5b4 Compare August 6, 2024 12:45
@agnesLeroy agnesLeroy marked this pull request as ready for review August 6, 2024 12:56
@agnesLeroy agnesLeroy requested a review from pdroalves August 7, 2024 07:43
@agnesLeroy agnesLeroy force-pushed the al/gpu_ci_on_hyperstack branch from ddbb5b4 to 772dcfe Compare August 7, 2024 07:45
@agnesLeroy agnesLeroy force-pushed the al/gpu_ci_on_hyperstack branch from 772dcfe to 4c40bb3 Compare August 7, 2024 08:04
@zama-bot zama-bot removed the approved label Aug 7, 2024
pdroalves
pdroalves approved these changes Aug 7, 2024
View reviewed changes
Copy link
Contributor

@pdroalves pdroalves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the limit of my knowledge, this PR seems consistent with what we want to do. I just found a missing "-" and added some questions, but couldn't find anything serious to change.

.github/workflows/gpu_full_multi_gpu_tests.yml Outdated Show resolved Hide resolved
scripts/integer-tests.sh Show resolved Hide resolved
@agnesLeroy agnesLeroy force-pushed the al/gpu_ci_on_hyperstack branch from 4c40bb3 to 50d5ed3 Compare August 7, 2024 13:30
@zama-bot zama-bot removed the approved label Aug 7, 2024
@agnesLeroy agnesLeroy merged commit 5340859 into main Aug 7, 2024
84 checks passed
@agnesLeroy agnesLeroy deleted the al/gpu_ci_on_hyperstack branch August 7, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdroalves pdroalves pdroalves approved these changes

@jborfila jborfila Awaiting requested review from jborfila

Assignees
No one assigned
Labels
approved cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@agnesLeroy @pdroalves @zama-bot