-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(integer): Adds bitslice operation #1453
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsarlin-zama
force-pushed
the
ns/feat/integer_slice
branch
9 times, most recently
from
August 6, 2024 10:40
c613d85
to
a70b139
Compare
Some questions:
|
nsarlin-zama
force-pushed
the
ns/feat/integer_slice
branch
2 times, most recently
from
August 6, 2024 13:09
6db0e90
to
9f8afe6
Compare
scalar_bitslice is good as as you said, we may add the encrypted version later |
tmontaigu
reviewed
Aug 7, 2024
tfhe/src/integer/server_key/radix_parallel/tests_unsigned/test_slice.rs
Outdated
Show resolved
Hide resolved
nsarlin-zama
force-pushed
the
ns/feat/integer_slice
branch
2 times, most recently
from
August 8, 2024 09:42
43a02d5
to
0e7d849
Compare
tmontaigu
reviewed
Aug 9, 2024
nsarlin-zama
force-pushed
the
ns/feat/integer_slice
branch
from
August 12, 2024 07:46
0e7d849
to
9abbc25
Compare
tmontaigu
reviewed
Aug 12, 2024
nsarlin-zama
force-pushed
the
ns/feat/integer_slice
branch
from
August 12, 2024 13:58
9abbc25
to
14014c9
Compare
tmontaigu
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: https://github.com/zama-ai/tfhe-rs-internal/issues/640
PR content/description
Adds a bitslice operation to the integer API. This operation extracts a range of bits from an integer. On native rust integers, this is roughly equivalent to the following operation:
On FHE radix integers, we have different cases based on the alignment of the slice bounds w.r.t the block size:
The returned ciphertext is filled with 0-trivial ciphertexts to match the input ciphertext size.
Check-list: