chore(all): use destructuring in conformance #1449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IceTDrinker
reviewed
Aug 13, 2024
| @@ -25,11 +25,18 @@ impl<T: UnsignedInteger> ParameterSetConformant for SeededLweCiphertext<T> { | |||
| type ParameterSet = LweCiphertextParameters<T>; | |||
|
|
|||
| fn is_conformant(&self, lwe_ct_parameters: &LweCiphertextParameters<T>) -> bool { | |||
| let Self { | |||
| data: _, | |||
There was a problem hiding this comment.
no need to ignore, change the from_ref below to use that scalar
| @@ -761,9 +761,14 @@ where | |||
| type ParameterSet = LweCiphertextParameters<C::Element>; | |||
|
|
|||
| fn is_conformant(&self, lwe_ct_parameters: &LweCiphertextParameters<C::Element>) -> bool { | |||
| let Self { | |||
| data: _, | |||
There was a problem hiding this comment.
do not ignore data and replace self in the check encrypted_content_respects_mod by data
Comment on lines
654
to
655
| == glwe_ct_parameters.glwe_dim.to_glwe_size().0 | ||
| * glwe_ct_parameters.polynomial_size.0 |
There was a problem hiding this comment.
if need be there should be a primitive that compute the glwe ciphertext size given a size/dim and a polynomial size
Comment on lines
53
to
56
| && modulus_switched_glwe_ciphertext_list.iter().all(|glwe| { | ||
| glwe.glwe_dimension() == params.ct_params.glwe_dim | ||
| && glwe.polynomial_size() == params.ct_params.polynomial_size | ||
| && glwe.uncompressed_ciphertext_modulus() == params.ct_params.ct_modulus |
There was a problem hiding this comment.
can we forward the conformance check to glwe.is_conformant maybe ?
| carry_modulus, | ||
| pbs_order, | ||
| lwe_per_glwe, | ||
| count: _, |
mayeul-zama
force-pushed
the
mz/destruct_conformance
branch
2 times, most recently
from
2bfa6ee to
88239f0
Compare
IceTDrinker
reviewed
Aug 22, 2024
Comment on lines
109
to
112
|
|
||
| pub const fn to_glwe_ct_size(self, poly_size: PolynomialSize) -> usize { | ||
| self.0 * poly_size.0 | ||
| } |
There was a problem hiding this comment.
glwe_ciphertext_size already exists as a free standing function in tfhe/src/core_crypto/entities/glwe_ciphertext.rs
Comment on lines
654
to
657
| == glwe_ct_parameters | ||
| .glwe_dim | ||
| .to_glwe_size() | ||
| .to_glwe_ct_size(glwe_ct_parameters.polynomial_size) |
mayeul-zama
force-pushed
the
mz/destruct_conformance
branch
from
88239f0 to
5cdc80f
Compare
IceTDrinker
approved these changes
Aug 23, 2024
|
looks like some auto imports do not work |
mayeul-zama
force-pushed
the
mz/destruct_conformance
branch
from
5cdc80f to
e6bec08
Compare
IceTDrinker
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.