chore(gpu): remove lwe chunk size argument from the multi-bit PBS #1445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we may have had some mismatch with this lwe_chunk_size argument, and maybe it was causing the unspecified launch failure. I'm running the H100 tests several times to check it. |
agnesLeroy
force-pushed
the
al/fix_lwe_chunkk_size_arg
branch
from
9a2f614 to
cc4721a
Compare
|
Now I'm wondering if we want to keep this argument, we're not using it actually... I've force pushed to the branch to remove it altogether. |
agnesLeroy
force-pushed
the
al/fix_lwe_chunkk_size_arg
branch
from
cc4721a to
2fe63c9
Compare
agnesLeroy
changed the title
pdroalves
approved these changes
Aug 1, 2024
backends/tfhe-cuda-backend/cuda/tests_and_benchmarks/benchmarks/benchmark_pbs.cpp
Show resolved
Hide resolved
pdroalves
requested changes
Aug 1, 2024
agnesLeroy
force-pushed
the
al/fix_lwe_chunkk_size_arg
branch
from
2fe63c9 to
91bfbef
Compare
|
I just made the change 🙂 - I triggered approval CI again via the label |
pdroalves
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: please link all relevant issues
PR content/description
Check-list: