Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Al/set higher max shared memory #1443

Merged
merged 1 commit into from
Aug 6, 2024
Merged

Al/set higher max shared memory #1443

merged 1 commit into from
Aug 6, 2024

Conversation

agnesLeroy
Copy link
Contributor

closes: please link all relevant issues

PR content/description

Check-list:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Relevant issues are marked as resolved/closed, related issues are linked in the description
  • Check for breaking changes (including serialization changes) and add them to commit message following the conventional commit specification

@cla-bot cla-bot bot added the cla-signed label Aug 1, 2024
@agnesLeroy agnesLeroy force-pushed the al/set_higher_max_shared_memory branch from ae907ff to a9d08a4 Compare August 1, 2024 08:26
@agnesLeroy
Copy link
Contributor Author

@bbarbakadze test time is reduced so it seems to have a nice effect on performance 🙂

@agnesLeroy agnesLeroy requested a review from bbarbakadze August 1, 2024 09:58
@agnesLeroy agnesLeroy marked this pull request as ready for review August 1, 2024 09:59
@agnesLeroy agnesLeroy force-pushed the al/set_higher_max_shared_memory branch from a9d08a4 to 6228c8f Compare August 1, 2024 11:34
@zama-bot zama-bot removed the approved label Aug 1, 2024
@agnesLeroy agnesLeroy force-pushed the al/set_higher_max_shared_memory branch 6 times, most recently from ce54586 to b7c01ad Compare August 6, 2024 08:29
@agnesLeroy agnesLeroy force-pushed the al/set_higher_max_shared_memory branch from b7c01ad to 5d4147d Compare August 6, 2024 08:36
bbarbakadze
bbarbakadze approved these changes Aug 6, 2024
View reviewed changes
Copy link
Contributor

@bbarbakadze bbarbakadze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't know much about workflows, rest of it looks good. Thanks.

@agnesLeroy agnesLeroy merged commit d69dd20 into main Aug 6, 2024
80 checks passed
@agnesLeroy agnesLeroy deleted the al/set_higher_max_shared_memory branch August 6, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbarbakadze bbarbakadze bbarbakadze approved these changes

Assignees
No one assigned
Labels
approved cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@agnesLeroy @bbarbakadze @zama-bot