Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/gpu/signed scalar comparisons #1053

Merged
merged 1 commit into from
Apr 10, 2024
Merged

Feat/gpu/signed scalar comparisons #1053

merged 1 commit into from
Apr 10, 2024

Conversation

pdroalves
Copy link
Contributor

closes: please link all relevant issues

PR content/description

Check-list:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Relevant issues are marked as resolved/closed, related issues are linked in the description
  • Check for breaking changes (including serialization changes) and add them to commit message following the conventional commit specification

@cla-bot cla-bot bot added the cla-signed label Apr 4, 2024
@pdroalves pdroalves force-pushed the feat/gpu/signed_scalar_comparisons branch 3 times, most recently from 7bc5756 to 6158d8c Compare April 4, 2024 19:37
@pdroalves
Copy link
Contributor Author

@slab-ci gpu_test

@slab-ci
Copy link

slab-ci bot commented Apr 5, 2024

Failed to add check run 'GPU AWS Tests' to check suite: http status 500 Internal Server Error code not expected

@agnesLeroy agnesLeroy force-pushed the feat/gpu/signed_scalar_comparisons branch from 6158d8c to da617e7 Compare April 5, 2024 11:55
@pdroalves pdroalves force-pushed the feat/gpu/signed_scalar_comparisons branch 2 times, most recently from 6d5c4c7 to c74686f Compare April 5, 2024 18:53
@pdroalves pdroalves marked this pull request as ready for review April 7, 2024 13:41
@pdroalves pdroalves force-pushed the feat/gpu/signed_scalar_comparisons branch 2 times, most recently from 4b8a7c0 to 3972e62 Compare April 8, 2024 19:51
@pdroalves pdroalves requested a review from agnesLeroy April 8, 2024 20:14
@pdroalves pdroalves force-pushed the feat/gpu/signed_scalar_comparisons branch from 3972e62 to f8af661 Compare April 8, 2024 20:19
@agnesLeroy agnesLeroy force-pushed the feat/gpu/signed_scalar_comparisons branch 2 times, most recently from 9f0f5b9 to 22dfeaa Compare April 9, 2024 07:39
@agnesLeroy agnesLeroy force-pushed the feat/gpu/signed_scalar_comparisons branch from 22dfeaa to f4dd724 Compare April 9, 2024 07:41
@zama-bot zama-bot removed the approved label Apr 9, 2024
@agnesLeroy agnesLeroy force-pushed the feat/gpu/signed_scalar_comparisons branch from f4dd724 to 782d052 Compare April 9, 2024 08:41
@zama-bot zama-bot removed the approved label Apr 9, 2024
@pdroalves pdroalves force-pushed the feat/gpu/signed_scalar_comparisons branch from 782d052 to fe9caf9 Compare April 9, 2024 13:28
@zama-bot zama-bot removed the approved label Apr 9, 2024
@agnesLeroy agnesLeroy merged commit 9576c5f into main Apr 10, 2024
14 checks passed
@agnesLeroy agnesLeroy deleted the feat/gpu/signed_scalar_comparisons branch April 10, 2024 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agnesLeroy agnesLeroy agnesLeroy approved these changes

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pdroalves @agnesLeroy @zama-bot