Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/gpu/signed comparisons #1041

Merged
merged 2 commits into from
Apr 3, 2024
Merged

Feat/gpu/signed comparisons #1041

merged 2 commits into from
Apr 3, 2024

Conversation

agnesLeroy
Copy link
Contributor

closes: please link all relevant issues

PR content/description

Check-list:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Relevant issues are marked as resolved/closed, related issues are linked in the description
  • Check for breaking changes (including serialization changes) and add them to commit message following the conventional commit specification

@cla-bot cla-bot bot added the cla-signed label Mar 29, 2024
@agnesLeroy agnesLeroy marked this pull request as ready for review March 29, 2024 17:33
@agnesLeroy agnesLeroy marked this pull request as draft March 29, 2024 17:33
@agnesLeroy agnesLeroy force-pushed the feat/gpu/signed_comparisons branch 2 times, most recently from adb8faa to fc7c334 Compare April 2, 2024 14:05
@agnesLeroy agnesLeroy force-pushed the feat/gpu/signed_comparisons branch from fc7c334 to 8f3e54e Compare April 3, 2024 07:28
@agnesLeroy agnesLeroy marked this pull request as ready for review April 3, 2024 07:29
@agnesLeroy agnesLeroy requested a review from IceTDrinker April 3, 2024 07:29
IceTDrinker
IceTDrinker reviewed Apr 3, 2024
View reviewed changes
Copy link
Member

@IceTDrinker IceTDrinker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as they say 😄

@agnesLeroy agnesLeroy force-pushed the feat/gpu/signed_comparisons branch from 8f3e54e to 7dd9a42 Compare April 3, 2024 07:44
@zama-bot zama-bot removed the approved label Apr 3, 2024
@agnesLeroy agnesLeroy merged commit 1fc3297 into main Apr 3, 2024
34 checks passed
@agnesLeroy agnesLeroy deleted the feat/gpu/signed_comparisons branch April 3, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IceTDrinker IceTDrinker IceTDrinker left review comments

Assignees
No one assigned
Labels
approved cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@agnesLeroy @IceTDrinker @zama-bot