Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat() Implement feature explained in the article #221

Merged
merged 14 commits into from
Nov 13, 2023
Merged

Conversation

immortal-tofu
Copy link
Collaborator

No description provided.

@cla-bot cla-bot bot added the cla-signed label Nov 8, 2023
@immortal-tofu immortal-tofu marked this pull request as ready for review November 8, 2023 14:55
Copy link
Contributor

@tremblaythibaultl tremblaythibaultl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

Copy link
Collaborator

@dartdart26 dartdart26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good to me!

The only thing I didn't fully understand is the need for delegatecall.

examples/Identity/AbstractCompliantERC20.sol Outdated Show resolved Hide resolved
examples/Identity/IdentityRegistry.sol Show resolved Hide resolved
@immortal-tofu immortal-tofu merged commit 4eea580 into main Nov 13, 2023
2 checks passed
@immortal-tofu immortal-tofu deleted the identity-update branch November 13, 2023 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants