Add network1 development support #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dartdart26
approved these changes
Oct 23, 2023
| to: "0x0000000000000000000000000000000000000044", | ||
| const ret = await provider.call({ | ||
| // fhe lib address | ||
| to: "0x000000000000000000000000000000000000005d", |
There was a problem hiding this comment.
Nit: Should we add a hint in the comment telling users to change the to address based on the network they are connecting to?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run one codegen to adapt TFHE library for network1, non-breaking. Some tests already passing. Tweaked the docs @immortal-tofu.
Remaining open questions:
How to adjust tests for the platforms which have operations disabled, say, disabled optimistic and synchronous requires for network1
@dartdart26 @youben11