[coprocessor] add inputs support for coprocessor #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-zk
changed the title
david-zk
force-pushed
the
davidk/inputs
branch
from
916f55e to
7a736a9
Compare
david-zk
force-pushed
the
davidk/inputs
branch
from
7a736a9 to
807a848
Compare
dartdart26
requested changes
Aug 23, 2024
fhevm-engine/Cargo.toml
Outdated
| @@ -3,5 +3,6 @@ resolver = "2" | |||
| members = ["coprocessor", "executor", "fhevm-engine-common"] | |||
|
|
|||
| [workspace.dependencies] | |||
| tfhe = { version = "0.8.0-alpha.2", features = ["boolean", "shortint", "integer", "aarch64-unix"] } | |||
| tfhe = { version = "0.8.0-alpha.2", features = ["boolean", "shortint", "integer", "aarch64-unix", "zk-pok"] } | |||
| tfhe-zk-pok = "0.2.1" | |||
There was a problem hiding this comment.
I think we don't need this dependency as the alpha version of tfhe has a dependency on 0.3...-alpha for tfhe-zk-pok. Or maybe you need to use the 0.3..-alpha one.
fhevm-engine/coprocessor/Cargo.toml
Outdated
| @@ -25,6 +25,7 @@ bigdecimal = "0.4" | |||
| fhevm-engine-common = { path = "../fhevm-engine-common" } | |||
| strum = { version = "0.26", features = ["derive"] } | |||
| bincode = "1.3.3" | |||
| keccak-asm = "0.1.3" | |||
There was a problem hiding this comment.
Doc for this crate says:
[!WARNING] Code is somewhat [tested](https://github.com/danipopes/keccak-asm/blob/HEAD/tests/test.rs) and [benchmarked](https://github.com/DaniPopes/bench-keccak256). Use at your own risk.
It doesn't have too much downloads. Maybe we can use a more popular one? Maybe sha3?
|
|
||
| for (ct_idx, the_ct) in corresponding_unpacked.iter().enumerate() { | ||
| let mut handle: [u8; 32] = [0; 32]; | ||
| handle.copy_from_slice(&blob_hash); |
There was a problem hiding this comment.
Don't we have to include the index in the hash computation, say hash(input_payload || index)? And then add the index as byte [29] too.
david-zk
force-pushed
the
davidk/inputs
branch
from
02f3c98 to
2f5ad0f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds inputs support for coprocessor
No signature verification yet.
Inputs endpoint:
@dartdart26 @immortal-tofu