Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: handle more potential errors for input lists #58

Merged
merged 1 commit into from
Oct 9, 2024
Merged

feat: handle more potential errors for input lists #58

merged 1 commit into from
Oct 9, 2024

Conversation

dartdart26
Copy link
Collaborator

  1. Use conformant input deserialization.
  2. Propagate errors after expansion of inputs instead of unwrap/expect.
  3. Wrap public params in an Arc to avoid copying it when deserializing in different threads.
  4. Update to tfhe-rs 0.8.2 for constructing conformance parameters out of public params.

@dartdart26
feat: handle more potential errors for input lists
e89f8ec 
1. Use conformant input deserialization.
2. Propagate errors after expansion of inputs instead of unwrap/expect.
3. Wrap public params in an Arc to avoid copying it when deserializing
in different threads.
4. Update to tfhe-rs 0.8.2 for constructing conformance parameters
out of public params.
@dartdart26 dartdart26 self-assigned this Oct 9, 2024
@dartdart26 dartdart26 merged commit 981ac7b into main Oct 9, 2024
2 checks passed
@dartdart26 dartdart26 deleted the petar/handle-input-errors branch October 9, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antoniupop antoniupop antoniupop approved these changes

@david-zk david-zk Awaiting requested review from david-zk

Assignees

@dartdart26 dartdart26

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dartdart26 @antoniupop