Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add possibility for multiple signatures to inputs upload #48

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

david-zk
Copy link
Contributor

@david-zk david-zk commented Oct 2, 2024

As we discussed in DMs kms nodes can create multiple signatures, we'd need to query KMS blockchain periodically to refresh the signers and validate their signatures of the requests

@titouantanguy @dartdart26 @antoniupop

Copy link

@titouantanguy titouantanguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure whether removing WaitComputations is related to the multiple signature thingy ?
But adding the repeated for signature LGTM.

@david-zk
Copy link
Contributor Author

david-zk commented Oct 2, 2024

Not sure whether removing WaitComputations is related to the multiple signature thingy ? But adding the repeated for signature LGTM.

Unrelated, just protobuf was regenerated

@david-zk david-zk merged commit 8d34c97 into main Oct 2, 2024
0 of 2 checks passed
@david-zk david-zk deleted the davidk/multiple-input-signatures branch October 2, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants