chore: add NatSpec FHEGasLimit #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jatZama
reviewed
Dec 26, 2024
jatZama
requested changes
Dec 26, 2024
There was a problem hiding this comment.
Please rework this PR to also put the modifications inside the codegen, since I remind you this contract is generated via codegen.
Please always check the diff is persisted here by doing npm run codegen, otherwise it doesn't make sense to merge those changes.
PacificYield
force-pushed
the
natspec-fhegaslimit
branch
from
c458b66 to
25ee6a6
Compare
PacificYield
force-pushed
the
natspec-fhegaslimit
branch
from
25ee6a6 to
cf4dab7
Compare
jatZama
approved these changes
Dec 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
FHEGasLimit.solcodegen (and its output) with NatSpec best practices.