Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add runnable workflow for core contracts #212

Merged
merged 1 commit into from
Dec 23, 2024
Merged

Conversation

0xawaz
Copy link
Collaborator

@0xawaz 0xawaz commented Dec 23, 2024

No description provided.

@0xawaz 0xawaz requested a review from jatZama December 23, 2024 12:43
@jatZama
Copy link
Member

jatZama commented Dec 23, 2024

Not sure why you removed the prerelease file.

@0xawaz
Copy link
Collaborator Author

0xawaz commented Dec 23, 2024

Not sure why you removed the prerelease file.

the publish file includes both release and prerelease with prerelease by default, I thought it would be no longer used

@jatZama
Copy link
Member

jatZama commented Dec 23, 2024

ok i noticed there is a new "inputs" parameter now for prerelease, but i m not a ci expert, so i m not sure i understand how this input will be setup when running jobs.

@0xawaz
Copy link
Collaborator Author

0xawaz commented Dec 23, 2024

ok i noticed there is a new "inputs" parameter now for prerelease, but i m not a ci expert, so i m not sure i understand how this input will be setup when running jobs.

By defaut, when you run the job, the release is set to false, which means it will run prerelease step, you need to change it to true in order to run the release step

@0xawaz 0xawaz merged commit 071c2f3 into main Dec 23, 2024
4 checks passed
@0xawaz 0xawaz deleted the ci/fhevm-core-contracts branch December 23, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants